Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #357 - Expose application nodes networking information #1333

Merged
merged 1 commit into from Mar 30, 2019

Conversation

@alexmt
Copy link
Contributor

alexmt commented Mar 28, 2019

PR implements API changes which are required to build network view ( #357 ). Now API /resouces-tree returns flat list of nodes. Each node has pointers parents end networkingInfo field with network connections.

@alexmt

This comment has been minimized.

Copy link
Contributor Author

alexmt commented Mar 29, 2019

@@ -112,5 +112,5 @@ const (
MinClientVersion = "0.12.0"
// CacheVersion is a objects version cached using util/cache/cache.go.
// Number should be bumped in case of backward incompatible change to make sure cache is invalidated after upgrade.
CacheVersion = "0.12.0"
CacheVersion = "0.12.1"

This comment has been minimized.

Copy link
@jessesuen

jessesuen Mar 30, 2019

Contributor

I think we should bump this to 0.13.0 so that we can associate the correct release this change was introduced in.

This comment has been minimized.

Copy link
@alexmt

alexmt Mar 30, 2019

Author Contributor

Done

case kube.ServiceKind:
return getServiceInfo(un)
}
case "apps", "extensions":

This comment has been minimized.

Copy link
@jessesuen

jessesuen Mar 30, 2019

Contributor

ingresses aren't in apps group, and only exist in extensions

This comment has been minimized.

Copy link
@alexmt

alexmt Mar 30, 2019

Author Contributor

Done

@alexmt alexmt force-pushed the alexmt:357-network-view branch from baad962 to 5a9dbff Mar 30, 2019
@alexmt alexmt merged commit 15dfa79 into argoproj:master Mar 30, 2019
1 of 2 checks passed
1 of 2 checks passed
default Argo CI workflow
Details
license/cla Contributor License Agreement is signed.
Details
@alexmt alexmt deleted the alexmt:357-network-view branch Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.