Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health check to the controller deployment #1785

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@alexmt
Copy link
Contributor

alexmt commented Jun 19, 2019

Closes #1782

@alexmt alexmt requested a review from jessesuen Jun 19, 2019
@alexmt alexmt force-pushed the alexmt:1782-controller-healthz branch from f86f4e7 to c55a883 Jun 19, 2019
@alexec
alexec approved these changes Jun 19, 2019
Copy link
Contributor

alexec left a comment

LGTM

@alexec

This comment has been minimized.

Copy link
Contributor

alexec commented Jun 19, 2019

Please run make pre-commit to fix manifests.

@alexmt alexmt force-pushed the alexmt:1782-controller-healthz branch from c55a883 to 6be9b9b Jun 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #1785 into master will increase coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
+ Coverage   34.51%   34.57%   +0.06%     
==========================================
  Files          78       78              
  Lines       11547    11551       +4     
==========================================
+ Hits         3985     3994       +9     
+ Misses       7011     7001      -10     
- Partials      551      556       +5
Impacted Files Coverage Δ
controller/appcontroller.go 39.66% <0%> (+1.04%) ⬆️
controller/metrics/metrics.go 94.5% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b55b1f...6be9b9b. Read the comment docs.

@alexmt alexmt merged commit 024dee0 into argoproj:master Jun 19, 2019
1 of 4 checks passed
1 of 4 checks passed
workflow Workflow: workflow
Details
ci/circleci: build CircleCI is running your tests
Details
ci/circleci: e2e CircleCI is running your tests
Details
license/cla Contributor License Agreement is signed.
Details
alexmt added a commit that referenced this pull request Jun 21, 2019
@alexmt alexmt deleted the alexmt:1782-controller-healthz branch Jul 15, 2019
@alexec alexec modified the milestones: v1.2, v1.1 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.