Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up the kube-version from Helm so that we can support GKE. #2304

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@alexec
Copy link
Contributor

alexec commented Sep 12, 2019

Closes #2303

@alexec alexec changed the title Clean-up the kube-version from Helm so that we can support GKE. Close… Clean-up the kube-version from Helm so that we can support GKE. Sep 12, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #2304 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
+ Coverage   38.85%   38.85%   +<.01%     
==========================================
  Files         105      105              
  Lines       14028    14030       +2     
==========================================
+ Hits         5450     5452       +2     
  Misses       7865     7865              
  Partials      713      713
Impacted Files Coverage Δ
util/text/text.go 100% <100%> (ø) ⬆️
util/helm/helm.go 70.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4511...d3aa4ad. Read the comment docs.

@alexec alexec marked this pull request as ready for review Sep 12, 2019
@alexec alexec requested review from jessesuen and alexmt Sep 12, 2019
@alexmt
alexmt approved these changes Sep 12, 2019
@alexec alexec merged commit 41b1b0a into argoproj:master Sep 12, 2019
7 checks passed
7 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: ui Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 38.85%)
Details
codecov/project 38.85% (+<.01%) compared to 12b4511
Details
license/cla Contributor License Agreement is signed.
Details
workflow Workflow: workflow
Details
@alexec alexec deleted the alexec:semver branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.