argocd-util should allow editing project policies in bulk #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
projects-backfill-util
branch
from
9fb524e
to
8dd6f21
Compare
Codecov Report
@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
- Coverage 37.93% 37.92% -0.02%
==========================================
Files 116 117 +1
Lines 16130 16259 +129
==========================================
+ Hits 6119 6166 +47
- Misses 9200 9274 +74
- Partials 811 819 +8
Continue to review full report at Codecov.
|
alexec
reviewed
Nov 1, 2019
alexec
reviewed
Nov 1, 2019
alexec
reviewed
Nov 1, 2019
alexec
reviewed
Nov 1, 2019
alexec
previously requested changes
Nov 1, 2019
added 2 commits
November 5, 2019 15:11
…ows to update multiple project policies
alexmt
force-pushed
the
projects-backfill-util
branch
from
64d6f0d
to
e88c9a0
Compare
|
@alexec can you take a look again please. your comments were addressed |
alexec
reviewed
Nov 21, 2019
| return command | ||
| } | ||
|
|
||
| func globMatch(pattern string, val string) bool { |
There was a problem hiding this comment.
rename val to something else? path?
| } | ||
|
|
||
| func globMatch(pattern string, val string) bool { | ||
| if pattern == "*" { |
There was a problem hiding this comment.
doesn't this get picked up by the filepath.Match?
|
|
||
| func getModification(modification string, resource string, scope string, permission string) (func(string, string) string, error) { | ||
| switch modification { | ||
| case "set": |
| } | ||
| actionPolicyIndex := -1 | ||
| for i := range role.Policies { | ||
| parts := split(role.Policies[i], ",") |
| updated = true | ||
| role.Policies = append(role.Policies[:actionPolicyIndex], role.Policies[actionPolicyIndex+1:]...) | ||
| } else if actionPolicyIndex > -1 && policyPermission != "" { | ||
| updated = true |
alexec
requested changes
Nov 26, 2019
alexec
approved these changes
Dec 5, 2019
alexmt
pushed a commit
that referenced
this pull request
Dec 5, 2019
* Implement 'argocd-util projects update-role-policy' command which allows to update multiple project policies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2614
Checklist:
CLI example: