Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduct secret values of manifests stored in git #3088

Merged
merged 1 commit into from Feb 7, 2020

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Feb 7, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to the README.
  • I've signed the CLA and my build is green (troubleshooting builds).

@alexmt alexmt requested a review from jessesuen February 7, 2020 01:02
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #3088 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3088      +/-   ##
=========================================
- Coverage   38.33%   38.3%   -0.03%     
=========================================
  Files         168     168              
  Lines       18189   18202      +13     
  Branches      272     272              
=========================================
  Hits         6973    6973              
- Misses      10342   10355      +13     
  Partials      874     874
Impacted Files Coverage Δ
server/application/application.go 26.13% <0%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1afe44...8075139. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 916d4ae into argoproj:master Feb 7, 2020
@Eriner
Copy link
Contributor

Eriner commented Feb 10, 2020

MITRE has assigned CVE-2018-21034 for this issue.

rytswd pushed a commit to rytswd/argo-cd that referenced this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants