Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Including namespace whiteliste resources support #3292

Merged
merged 4 commits into from
Mar 26, 2020
Merged

feat: Including namespace whiteliste resources support #3292

merged 4 commits into from
Mar 26, 2020

Conversation

rachelwang20
Copy link
Contributor

@rachelwang20 rachelwang20 commented Mar 26, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Issue link: #2900

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2020

CLA assistant check
All committers have signed the CLA.

@rachelwang20 rachelwang20 changed the title Including namespace whiteliste resources support - #2900 feat: Including namespace whiteliste resources support Mar 26, 2020
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/apis/application/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/application/v1alpha1/types_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #3292 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3292      +/-   ##
==========================================
- Coverage   39.05%   39.03%   -0.03%     
==========================================
  Files          48      173     +125     
  Lines        1398    18811   +17413     
  Branches      272      272              
==========================================
+ Hits          546     7343    +6797     
- Misses        845    10548    +9703     
- Partials        7      920     +913
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 63.35% <100%> (ø)
cmd/argocd/commands/completion.go 0% <0%> (ø)
util/helm/client.go 57.37% <0%> (ø)
util/helm/index.go 80% <0%> (ø)
util/exec/exec.go 88.88% <0%> (ø)
util/kustomize/kustomize.go 71.3% <0%> (ø)
util/resource/annotations.go 100% <0%> (ø)
util/oidc/oidc.go 7.57% <0%> (ø)
server/account/account.go 63.02% <0%> (ø)
util/swagger/swagger.go 100% <0%> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0162971...120d507. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @rachelwang20 !

@alexmt alexmt merged commit e3a18b9 into argoproj:master Mar 26, 2020
@rachelwang20 rachelwang20 self-assigned this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants