fix: increase max grpc message size #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
grpc-message-size
branch
from
2538e9d
to
3536e44
Compare
jannfis
approved these changes
Nov 20, 2020
| // MaxGRPCMessageSize contains max grpc message size | ||
| MaxGRPCMessageSize = 100 * 1024 * 1024 | ||
| MaxGRPCMessageSize = env.ParseNumFromEnv(EnvArgoCDgRPCMaxSizeMB, 200, 0, math.MaxInt32) * 1024 * 1024 |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
grpc-message-size
branch
from
3536e44
to
2415cf5
Compare
|
Good point @jannfis . Documented env variable. |
alexmt
pushed a commit
that referenced
this pull request
Nov 20, 2020
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
pushed a commit
that referenced
this pull request
Nov 20, 2020
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR increases max grpc message size. The change is workaround for #4868