Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies. Fixes/refactoring to kube libraries #729

Merged
merged 1 commit into from Oct 29, 2018

Conversation

@jessesuen
Copy link
Contributor

jessesuen commented Oct 27, 2018

Update dependencies to k8s v1.12 and client-go v9.0 (resolves #353)
Fix issue where applications could not be deleted on k8s v1.12 (resolves #718)
Refactor k8s dynamic resource libraries to promote code reuse

@jessesuen jessesuen requested review from alexmt, merenbach and dthomson25 Oct 27, 2018
Fix issue where applications could not be deleted on k8s v1.12
Refactor k8s dynamic resource libraries to promote code reuse
@jessesuen jessesuen force-pushed the jessesuen:353-client-go branch from c166dd5 to ec15ee9 Oct 27, 2018
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #729 into master will increase coverage by 0.31%.
The diff coverage is 15.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   22.05%   22.37%   +0.31%     
==========================================
  Files          40       40              
  Lines        6288     6252      -36     
==========================================
+ Hits         1387     1399      +12     
+ Misses       4714     4666      -48     
  Partials      187      187
Impacted Files Coverage Δ
util/kube/ctl.go 12.38% <0%> (+2.3%) ⬆️
controller/appcontroller.go 11.8% <0%> (ø) ⬆️
controller/sync.go 28.64% <0%> (ø) ⬆️
controller/state.go 2.9% <0%> (+0.01%) ⬆️
util/kube/kube.go 24.72% <20.51%> (+3.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e390e7...ec15ee9. Read the comment docs.

@jessesuen jessesuen merged commit 2498f60 into argoproj:master Oct 29, 2018
2 checks passed
2 checks passed
default Argo CI
Details
license/cla Contributor License Agreement is signed.
Details
jessesuen added a commit that referenced this pull request Nov 13, 2018
Update dependencies to k8s v1.12 and client-go v9.0 (resolves #353)
Fix issue where applications could not be deleted on k8s v1.12 (resolves #718)
Refactor k8s dynamic resource libraries to promote code reuse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.