-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update notification engine #9386
refactor: Update notification engine #9386
Conversation
Signed-off-by: todaywasawesome <dan@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #9386 +/- ##
==========================================
- Coverage 46.22% 45.71% -0.51%
==========================================
Files 218 221 +3
Lines 25914 26289 +375
==========================================
+ Hits 11978 12019 +41
- Misses 12278 12610 +332
- Partials 1658 1660 +2
Continue to review full report at Codecov.
|
@todaywasawesome I'm not opposed! Looks like it needs a |
Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: todaywasawesome <dan@codefresh.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes in notification-engine one more time .
Looks like PR would pull in several bug fixes and new features that would be good to test. So I think it is good idea to bump notification engine version even though we are very close to the release.
refactor: Update notification engine (#9386) Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: todaywasawesome dan@codefresh.io
Notification Engine is several months behind and includes several bug fixes and two additional features.
@crenshaw-dev @alexmt There is an open question if we should cherrypick this into 2.4. Given how far behind the current package is, my instinct is that we should include it. Argo Rollouts is using a version from Jan '22 while CD is using one from Nov '21.
CC @kevinchen-verkada who is advocating for these changes.