Add ProgressDeadlineSeconds #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 76.14% 77.11% +0.96%
==========================================
Files 14 14
Lines 1417 1595 +178
==========================================
+ Hits 1079 1230 +151
- Misses 259 278 +19
- Partials 79 87 +8
Continue to review full report at Codecov.
|
alexmt
requested changes
Apr 22, 2019
controller/service.go
Outdated
| c.recorder.Eventf(r, corev1.EventTypeWarning, conditions.ServiceNotFoundReason, msg) | ||
| cond := conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionFalse, conditions.ServiceNotFoundReason, msg) | ||
| conditions.SetRolloutCondition(&r.Status, *cond) | ||
| c.rolloutsclientset.ArgoprojV1alpha1().Rollouts(r.Namespace).Update(r) |
There was a problem hiding this comment.
I think we should use Patch to set conditions.
controller/service.go
Outdated
| c.recorder.Eventf(r, corev1.EventTypeWarning, conditions.ServiceNotFoundReason, msg) | ||
| cond := conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionFalse, conditions.ServiceNotFoundReason, msg) | ||
| conditions.SetRolloutCondition(&r.Status, *cond) | ||
| c.rolloutsclientset.ArgoprojV1alpha1().Rollouts(r.Namespace).Update(r) |
controller/service.go
Outdated
| @@ -130,7 +134,11 @@ func (c *Controller) getPreviewAndActiveServices(r *v1alpha1.Rollout) (*corev1.S | |||
| activeSvc, err = c.kubeclientset.CoreV1().Services(r.Namespace).Get(r.Spec.Strategy.BlueGreenStrategy.ActiveService, metav1.GetOptions{}) | |||
| if err != nil { | |||
| if errors.IsNotFound(err) { | |||
| logCtx.Warnf("Service %v does not exist", r.Spec.Strategy.BlueGreenStrategy.PreviewService) | |||
| msg := fmt.Sprintf(conditions.ServiceNotFoundMessage, "active", r.Spec.Strategy.BlueGreenStrategy.ActiveService) | |||
utils/conditions/conditions.go
Outdated
|
|
||
| // Reasons and Messages for rollout conditions | ||
|
|
||
| // Progressing: |
dthomson25
force-pushed
the
add-deadlines
branch
from
6ae4313
to
370dc57
Compare
This was referenced Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I simplified the testing framework to allow developers to test specific fields within the objects sent to the Kubernetes API instead of the entire object.