-
Notifications
You must be signed in to change notification settings - Fork 3.2k
/
operator.go
382 lines (339 loc) · 14 KB
/
operator.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
package cron
import (
"context"
"encoding/json"
"fmt"
"sort"
"time"
"github.com/robfig/cron/v3"
log "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/util/retry"
"github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
"github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned"
typed "github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned/typed/workflow/v1alpha1"
errorsutil "github.com/argoproj/argo-workflows/v3/util/errors"
waitutil "github.com/argoproj/argo-workflows/v3/util/wait"
"github.com/argoproj/argo-workflows/v3/workflow/common"
"github.com/argoproj/argo-workflows/v3/workflow/metrics"
"github.com/argoproj/argo-workflows/v3/workflow/templateresolution"
"github.com/argoproj/argo-workflows/v3/workflow/util"
"github.com/argoproj/argo-workflows/v3/workflow/validate"
)
type cronWfOperationCtx struct {
// CronWorkflow is the CronWorkflow to be run
name string
cronWf *v1alpha1.CronWorkflow
wfClientset versioned.Interface
wfClient typed.WorkflowInterface
cronWfIf typed.CronWorkflowInterface
log *log.Entry
metrics *metrics.Metrics
// scheduledTimeFunc returns the last scheduled time when it is called
scheduledTimeFunc ScheduledTimeFunc
}
func newCronWfOperationCtx(cronWorkflow *v1alpha1.CronWorkflow, wfClientset versioned.Interface, metrics *metrics.Metrics) *cronWfOperationCtx {
return &cronWfOperationCtx{
name: cronWorkflow.ObjectMeta.Name,
cronWf: cronWorkflow,
wfClientset: wfClientset,
wfClient: wfClientset.ArgoprojV1alpha1().Workflows(cronWorkflow.Namespace),
cronWfIf: wfClientset.ArgoprojV1alpha1().CronWorkflows(cronWorkflow.Namespace),
log: log.WithFields(log.Fields{
"workflow": cronWorkflow.ObjectMeta.Name,
"namespace": cronWorkflow.ObjectMeta.Namespace,
}),
metrics: metrics,
// inferScheduledTime returns an inferred scheduled time based on the current time and only works if it is called
// within 59 seconds of the scheduled time. Here it acts as a placeholder until it is replaced by a similar
// function that returns the last scheduled time deterministically from the cron engine. Since we are only able
// to generate the latter function after the job is scheduled, there is a tiny chance that the job is run before
// the deterministic function is supplanted. If that happens, we use the infer function as the next-best thing
scheduledTimeFunc: inferScheduledTime,
}
}
// Run handles the running of a cron workflow
// It fits the github.com/robfig/cron.Job interface
func (woc *cronWfOperationCtx) Run() {
ctx := context.Background()
woc.run(ctx, woc.scheduledTimeFunc())
}
func (woc *cronWfOperationCtx) run(ctx context.Context, scheduledRuntime time.Time) {
defer woc.persistUpdate(ctx)
woc.log.Infof("Running %s", woc.name)
err := woc.validateCronWorkflow()
if err != nil {
return
}
proceed, err := woc.enforceRuntimePolicy(ctx)
if err != nil {
woc.reportCronWorkflowError(v1alpha1.ConditionTypeSubmissionError, fmt.Sprintf("Concurrency policy error: %s", err))
return
} else if !proceed {
return
}
wf := common.ConvertCronWorkflowToWorkflowWithProperties(woc.cronWf, getChildWorkflowName(woc.cronWf.Name, scheduledRuntime), scheduledRuntime)
runWf, err := util.SubmitWorkflow(ctx, woc.wfClient, woc.wfClientset, woc.cronWf.Namespace, wf, &v1alpha1.SubmitOpts{})
if err != nil {
// If the workflow already exists (i.e. this is a duplicate submission), do not report an error
if errors.IsAlreadyExists(err) {
return
}
woc.reportCronWorkflowError(v1alpha1.ConditionTypeSubmissionError, fmt.Sprintf("Failed to submit Workflow: %s", err))
return
}
woc.cronWf.Status.Active = append(woc.cronWf.Status.Active, getWorkflowObjectReference(wf, runWf))
woc.cronWf.Status.LastScheduledTime = &v1.Time{Time: scheduledRuntime}
woc.cronWf.Status.Conditions.RemoveCondition(v1alpha1.ConditionTypeSubmissionError)
}
func (woc *cronWfOperationCtx) validateCronWorkflow() error {
wftmplGetter := templateresolution.WrapWorkflowTemplateInterface(woc.wfClientset.ArgoprojV1alpha1().WorkflowTemplates(woc.cronWf.Namespace))
cwftmplGetter := templateresolution.WrapClusterWorkflowTemplateInterface(woc.wfClientset.ArgoprojV1alpha1().ClusterWorkflowTemplates())
err := validate.ValidateCronWorkflow(wftmplGetter, cwftmplGetter, woc.cronWf)
if err != nil {
woc.reportCronWorkflowError(v1alpha1.ConditionTypeSpecError, fmt.Sprint(err))
} else {
woc.cronWf.Status.Conditions.RemoveCondition(v1alpha1.ConditionTypeSpecError)
}
return err
}
func getWorkflowObjectReference(wf *v1alpha1.Workflow, runWf *v1alpha1.Workflow) corev1.ObjectReference {
// This is a bit of a hack. Ideally we'd use ref.GetReference, but for some reason the `runWf` object is coming back
// without `Kind` and `APIVersion` set (even though it it set on `wf`). To fix this, we hard code those values.
return corev1.ObjectReference{
Kind: wf.Kind,
APIVersion: wf.APIVersion,
Name: runWf.GetName(),
Namespace: runWf.GetNamespace(),
UID: runWf.GetUID(),
ResourceVersion: runWf.GetResourceVersion(),
}
}
func (woc *cronWfOperationCtx) persistUpdate(ctx context.Context) {
woc.patch(ctx, map[string]interface{}{"status": woc.cronWf.Status})
}
func (woc *cronWfOperationCtx) persistUpdateActiveWorkflows(ctx context.Context) {
woc.patch(ctx, map[string]interface{}{"status": map[string]interface{}{"active": woc.cronWf.Status.Active}})
}
func (woc *cronWfOperationCtx) patch(ctx context.Context, patch map[string]interface{}) {
data, err := json.Marshal(patch)
if err != nil {
woc.log.WithError(err).Error("failed to marshall cron workflow status.active data")
return
}
err = waitutil.Backoff(retry.DefaultBackoff, func() (bool, error) {
cronWf, err := woc.cronWfIf.Patch(ctx, woc.cronWf.Name, types.MergePatchType, data, v1.PatchOptions{})
if err != nil {
return !errorsutil.IsTransientErr(err), err
}
woc.cronWf = cronWf
return true, nil
})
if err != nil {
woc.log.WithError(err).Error("failed to data cron workflow")
return
}
}
func (woc *cronWfOperationCtx) enforceRuntimePolicy(ctx context.Context) (bool, error) {
if woc.cronWf.Spec.Suspend {
woc.log.Infof("%s is suspended, skipping execution", woc.name)
return false, nil
}
if woc.cronWf.Spec.ConcurrencyPolicy != "" {
switch woc.cronWf.Spec.ConcurrencyPolicy {
case v1alpha1.AllowConcurrent, "":
// Do nothing
case v1alpha1.ForbidConcurrent:
if len(woc.cronWf.Status.Active) > 0 {
woc.log.Infof("%s has 'ConcurrencyPolicy: Forbid' and has an active Workflow so it was not run", woc.name)
return false, nil
}
case v1alpha1.ReplaceConcurrent:
if len(woc.cronWf.Status.Active) > 0 {
woc.log.Infof("%s has 'ConcurrencyPolicy: Replace' and has active Workflows", woc.name)
err := woc.terminateOutstandingWorkflows(ctx)
if err != nil {
return false, err
}
}
default:
return false, fmt.Errorf("invalid ConcurrencyPolicy: %s", woc.cronWf.Spec.ConcurrencyPolicy)
}
}
return true, nil
}
func (woc *cronWfOperationCtx) terminateOutstandingWorkflows(ctx context.Context) error {
for _, wfObjectRef := range woc.cronWf.Status.Active {
woc.log.Infof("stopping '%s'", wfObjectRef.Name)
err := util.TerminateWorkflow(ctx, woc.wfClient, wfObjectRef.Name)
if err != nil {
if errors.IsNotFound(err) {
woc.log.Warnf("workflow '%s' not found when trying to terminate outstanding workflows", wfObjectRef.Name)
continue
}
return fmt.Errorf("error stopping workflow %s: %e", wfObjectRef.Name, err)
}
}
return nil
}
func (woc *cronWfOperationCtx) runOutstandingWorkflows(ctx context.Context) (bool, error) {
missedExecutionTime, err := woc.shouldOutstandingWorkflowsBeRun()
if err != nil {
return false, err
}
if !missedExecutionTime.IsZero() {
woc.run(ctx, missedExecutionTime)
return true, nil
}
return false, nil
}
func (woc *cronWfOperationCtx) shouldOutstandingWorkflowsBeRun() (time.Time, error) {
// If this CronWorkflow has been run before, check if we have missed any scheduled executions
if woc.cronWf.Status.LastScheduledTime != nil {
var now time.Time
var cronSchedule cron.Schedule
if woc.cronWf.Spec.Timezone != "" {
loc, err := time.LoadLocation(woc.cronWf.Spec.Timezone)
if err != nil {
return time.Time{}, fmt.Errorf("invalid timezone '%s': %s", woc.cronWf.Spec.Timezone, err)
}
now = time.Now().In(loc)
cronScheduleString := "CRON_TZ=" + woc.cronWf.Spec.Timezone + " " + woc.cronWf.Spec.Schedule
cronSchedule, err = cron.ParseStandard(cronScheduleString)
if err != nil {
return time.Time{}, fmt.Errorf("unable to form timezone schedule '%s': %s", cronScheduleString, err)
}
} else {
var err error
now = time.Now()
cronSchedule, err = cron.ParseStandard(woc.cronWf.Spec.Schedule)
if err != nil {
return time.Time{}, err
}
}
var missedExecutionTime time.Time
nextScheduledRunTime := cronSchedule.Next(woc.cronWf.Status.LastScheduledTime.Time)
// Workflow should have ran
for nextScheduledRunTime.Before(now) {
missedExecutionTime = nextScheduledRunTime
nextScheduledRunTime = cronSchedule.Next(missedExecutionTime)
}
// We missed the latest execution time
if !missedExecutionTime.IsZero() {
// If StartingDeadlineSeconds is not set, or we are still within the deadline window, run the Workflow
if woc.cronWf.Spec.StartingDeadlineSeconds == nil || *woc.cronWf.Spec.StartingDeadlineSeconds == 0 || now.Before(missedExecutionTime.Add(time.Duration(*woc.cronWf.Spec.StartingDeadlineSeconds)*time.Second)) {
woc.log.Infof("%s missed an execution at %s and is within StartingDeadline", woc.cronWf.Name, missedExecutionTime.Format("Mon Jan _2 15:04:05 2006"))
return missedExecutionTime, nil
}
}
}
return time.Time{}, nil
}
func (woc *cronWfOperationCtx) reconcileActiveWfs(ctx context.Context, workflows []v1alpha1.Workflow) error {
updated := false
currentWfsFulfilled := make(map[types.UID]bool)
for _, wf := range workflows {
currentWfsFulfilled[wf.UID] = wf.Status.Fulfilled()
if !woc.cronWf.Status.HasActiveUID(wf.UID) && !wf.Status.Fulfilled() {
updated = true
woc.cronWf.Status.Active = append(woc.cronWf.Status.Active, getWorkflowObjectReference(&wf, &wf))
}
}
for _, objectRef := range woc.cronWf.Status.Active {
if fulfilled, found := currentWfsFulfilled[objectRef.UID]; !found || fulfilled {
updated = true
woc.removeFromActiveList(objectRef.UID)
}
}
if updated {
woc.persistUpdateActiveWorkflows(ctx)
}
return nil
}
func (woc *cronWfOperationCtx) removeFromActiveList(uid types.UID) {
var newActive []corev1.ObjectReference
for _, ref := range woc.cronWf.Status.Active {
if ref.UID != uid {
newActive = append(newActive, ref)
}
}
woc.cronWf.Status.Active = newActive
}
func (woc *cronWfOperationCtx) enforceHistoryLimit(ctx context.Context, workflows []v1alpha1.Workflow) error {
woc.log.Infof("Enforcing history limit for '%s'", woc.cronWf.Name)
var successfulWorkflows []v1alpha1.Workflow
var failedWorkflows []v1alpha1.Workflow
for _, wf := range workflows {
if wf.Labels[common.LabelKeyCronWorkflow] != woc.cronWf.Name {
continue
}
if wf.Status.Fulfilled() {
if wf.Status.Successful() {
successfulWorkflows = append(successfulWorkflows, wf)
} else {
failedWorkflows = append(failedWorkflows, wf)
}
}
}
workflowsToKeep := int32(3)
if woc.cronWf.Spec.SuccessfulJobsHistoryLimit != nil && *woc.cronWf.Spec.SuccessfulJobsHistoryLimit >= 0 {
workflowsToKeep = *woc.cronWf.Spec.SuccessfulJobsHistoryLimit
}
err := woc.deleteOldestWorkflows(ctx, successfulWorkflows, int(workflowsToKeep))
if err != nil {
return fmt.Errorf("unable to delete Successful Workflows of CronWorkflow '%s': %s", woc.cronWf.Name, err)
}
workflowsToKeep = int32(1)
if woc.cronWf.Spec.FailedJobsHistoryLimit != nil && *woc.cronWf.Spec.FailedJobsHistoryLimit >= 0 {
workflowsToKeep = *woc.cronWf.Spec.FailedJobsHistoryLimit
}
err = woc.deleteOldestWorkflows(ctx, failedWorkflows, int(workflowsToKeep))
if err != nil {
return fmt.Errorf("unable to delete Failed Workflows of CronWorkflow '%s': %s", woc.cronWf.Name, err)
}
return nil
}
func (woc *cronWfOperationCtx) deleteOldestWorkflows(ctx context.Context, jobList []v1alpha1.Workflow, workflowsToKeep int) error {
if workflowsToKeep >= len(jobList) {
return nil
}
sort.SliceStable(jobList, func(i, j int) bool {
return jobList[i].Status.FinishedAt.Time.After(jobList[j].Status.FinishedAt.Time)
})
for _, wf := range jobList[workflowsToKeep:] {
err := woc.wfClient.Delete(ctx, wf.Name, v1.DeleteOptions{})
if err != nil {
if errors.IsNotFound(err) {
woc.log.Infof("Workflow '%s' was already deleted", wf.Name)
continue
}
return fmt.Errorf("error deleting workflow '%s': %e", wf.Name, err)
}
woc.log.Infof("Deleted Workflow '%s' due to CronWorkflow '%s' history limit", wf.Name, woc.cronWf.Name)
}
return nil
}
func (woc *cronWfOperationCtx) reportCronWorkflowError(conditionType v1alpha1.ConditionType, errString string) {
woc.log.WithField("conditionType", conditionType).Error(errString)
woc.cronWf.Status.Conditions.UpsertCondition(v1alpha1.Condition{
Type: conditionType,
Message: errString,
Status: v1.ConditionTrue,
})
woc.metrics.CronWorkflowSubmissionError()
}
func inferScheduledTime() time.Time {
// Infer scheduled runtime by getting current time and zeroing out current seconds and nanoseconds
// This works because the finest possible scheduled runtime is a minute. It is unlikely to ever be used, since this
// function is quickly supplanted by a deterministic function from the cron engine.
now := time.Now().UTC()
scheduledTime := time.Date(now.Year(), now.Month(), now.Day(), now.Hour(), now.Minute(), 0, 0, now.Location())
log.Infof("inferred scheduled time: %s", scheduledTime)
return scheduledTime
}
func getChildWorkflowName(cronWorkflowName string, scheduledRuntime time.Time) string {
return fmt.Sprintf("%s-%d", cronWorkflowName, scheduledRuntime.Unix())
}