From 0076cc2bf4014c2c8a649dd70852c360333f78f2 Mon Sep 17 00:00:00 2001
From: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Date: Sun, 26 May 2024 21:36:15 -0400
Subject: [PATCH] refactor(ui): heavily simplify `WorkflowCreator` effect
 (#13094)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
---
 .../workflows/components/workflow-creator.tsx | 44 +++++++++----------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/ui/src/app/workflows/components/workflow-creator.tsx b/ui/src/app/workflows/components/workflow-creator.tsx
index 31ea9e3e5a92..51187771900b 100644
--- a/ui/src/app/workflows/components/workflow-creator.tsx
+++ b/ui/src/app/workflows/components/workflow-creator.tsx
@@ -31,30 +31,28 @@ export function WorkflowCreator({namespace, onCreate}: {namespace: string; onCre
     }, [namespace]);
 
     useEffect(() => {
-        switch (stage) {
-            case 'full-editor':
-                if (workflowTemplate) {
-                    setWorkflow({
-                        metadata: {
-                            generateName: workflowTemplate.metadata.name + '-',
-                            namespace,
-                            labels: {
-                                'workflows.argoproj.io/workflow-template': workflowTemplate.metadata.name,
-                                'submit-from-ui': 'true'
-                            }
-                        },
-                        spec: {
-                            arguments: workflowTemplate.spec.arguments,
-                            workflowTemplateRef: {
-                                name: workflowTemplate.metadata.name
-                            }
-                        }
-                    });
-                } else {
-                    setWorkflow(exampleWorkflow(Utils.getNamespaceWithDefault(namespace)));
-                }
-                break;
+        if (stage !== 'full-editor') return;
+        if (!workflowTemplate) {
+            setWorkflow(exampleWorkflow(Utils.getNamespaceWithDefault(namespace)));
+            return;
         }
+
+        setWorkflow({
+            metadata: {
+                generateName: workflowTemplate.metadata.name + '-',
+                namespace,
+                labels: {
+                    'workflows.argoproj.io/workflow-template': workflowTemplate.metadata.name,
+                    'submit-from-ui': 'true'
+                }
+            },
+            spec: {
+                arguments: workflowTemplate.spec.arguments,
+                workflowTemplateRef: {
+                    name: workflowTemplate.metadata.name
+                }
+            }
+        });
     }, [stage]);
 
     useEffect(() => {