fix: comment

Signed-off-by: shuangkun <tsk2013uestc@163.com>
argoproj · Mar 24, 2024 · 19d2f5c · 19d2f5c
1 parent 9fe5934
commit 19d2f5c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/workflow/controller/controller_test.go b/workflow/controller/controller_test.go
@@ -548,7 +548,7 @@ func makePodsPhase(ctx context.Context, woc *wfOperationCtx, phase apiv1.PodPhas
 func deletePods(ctx context.Context, woc *wfOperationCtx) {
 	for _, obj := range woc.controller.podInformer.GetStore().List() {
 		pod := obj.(*apiv1.Pod)
-		err := woc.controller.kubeclientset.CoreV1().Pods(pod.Namespace).Delete(ctx, pod.Name, metav1.DeleteOptions{GracePeriodSeconds: pointer.Int64Ptr(0)})
+		err := woc.controller.kubeclientset.CoreV1().Pods(pod.Namespace).Delete(ctx, pod.Name, metav1.DeleteOptions{})
 		if err != nil {
 			panic(err)
 		}

diff --git a/workflow/controller/operator_test.go b/workflow/controller/operator_test.go
@@ -10845,7 +10845,6 @@ spec:
 
 // TestContainerSetDeleteContainerWhenPodDeleted test whether a workflow has ContainerSet error when pod deleted.
 func TestContainerSetDeleteContainerWhenPodDeleted(t *testing.T) {
-	_ = os.Setenv("RECENTLY_STARTED_POD_DURATION", "0")
 	cancel, controller := newController()
 	defer cancel()
 	ctx := context.Background()
@@ -10872,6 +10871,7 @@ func TestContainerSetDeleteContainerWhenPodDeleted(t *testing.T) {
 	}
 
 	// delete pod
+	time.Sleep(1 * time.Second)
 	deletePods(ctx, woc)
 	pods, err = listPods(woc)
 	assert.Nil(t, err)
@@ -10890,5 +10890,4 @@ func TestContainerSetDeleteContainerWhenPodDeleted(t *testing.T) {
 			assert.Equal(t, "container deleted", node.Message)
 		}
 	}
-	_ = os.Unsetenv("RECENTLY_STARTED_POD_DURATION")
 }