From 31b28897a3b71db7c285331a8a40e29861e380c1 Mon Sep 17 00:00:00 2001 From: shuangkun Date: Sun, 7 Apr 2024 01:56:11 +0800 Subject: [PATCH] fix: comments Signed-off-by: shuangkun --- workflow/util/util_test.go | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/workflow/util/util_test.go b/workflow/util/util_test.go index 033ca09fc8ec..a9cf51283908 100644 --- a/workflow/util/util_test.go +++ b/workflow/util/util_test.go @@ -1378,11 +1378,11 @@ func TestFormulateRetryWorkflow(t *testing.T) { Phase: wfv1.WorkflowFailed, Nodes: map[string]wfv1.NodeStatus{ "continue-on-failed-workflow": {ID: "continue-on-failed-workflow", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypeDAG, Children: []string{"1"}, OutboundNodes: []string{"3", "5"}}, - "1": {ID: "1", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Children: []string{"2", "4"}, Name: "node1"}, - "2": {ID: "2", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Children: []string{"3"}, Name: "node2"}, - "3": {ID: "3", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Name: "node3"}, - "4": {ID: "4", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Children: []string{"5"}, Name: "node4"}, - "5": {ID: "5", Phase: wfv1.NodeOmitted, Type: wfv1.NodeTypeSkipped, BoundaryID: "failed-workflow", Name: "node5"}}, + "1": {ID: "1", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Children: []string{"2", "4"}, Name: "node1"}, + "2": {ID: "2", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Children: []string{"3"}, Name: "node2"}, + "3": {ID: "3", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Name: "node3"}, + "4": {ID: "4", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Children: []string{"5"}, Name: "node4"}, + "5": {ID: "5", Phase: wfv1.NodeOmitted, Type: wfv1.NodeTypeSkipped, BoundaryID: "continue-on-failed-workflow", Name: "node5"}}, }, } _, err := wfClient.Create(ctx, wf, metav1.CreateOptions{}) @@ -1407,11 +1407,11 @@ func TestFormulateRetryWorkflow(t *testing.T) { Phase: wfv1.WorkflowFailed, Nodes: map[string]wfv1.NodeStatus{ "continue-on-failed-workflow": {ID: "continue-on-failed-workflow", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypeDAG, Children: []string{"1"}, OutboundNodes: []string{"3", "5"}}, - "1": {ID: "1", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Children: []string{"2", "4"}, Name: "node1"}, - "2": {ID: "2", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Children: []string{"3"}, Name: "node2"}, - "3": {ID: "3", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Name: "node3"}, - "4": {ID: "4", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "failed-workflow", Children: []string{"5"}, Name: "node4"}, - "5": {ID: "5", Phase: wfv1.NodeOmitted, Type: wfv1.NodeTypeSkipped, BoundaryID: "failed-workflow", Name: "node5"}}, + "1": {ID: "1", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Children: []string{"2", "4"}, Name: "node1"}, + "2": {ID: "2", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Children: []string{"3"}, Name: "node2"}, + "3": {ID: "3", Phase: wfv1.NodeSucceeded, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Name: "node3"}, + "4": {ID: "4", Phase: wfv1.NodeFailed, Type: wfv1.NodeTypePod, BoundaryID: "continue-on-failed-workflow", Children: []string{"5"}, Name: "node4"}, + "5": {ID: "5", Phase: wfv1.NodeOmitted, Type: wfv1.NodeTypeSkipped, BoundaryID: "continue-on-failed-workflow", Name: "node5"}}, }, } _, err := wfClient.Create(ctx, wf, metav1.CreateOptions{}) @@ -1419,8 +1419,8 @@ func TestFormulateRetryWorkflow(t *testing.T) { wf, podsToDelete, err := FormulateRetryWorkflow(ctx, wf, true, "id=3", nil) if assert.NoError(t, err) { if assert.Len(t, wf.Status.Nodes, 2) { - assert.Equal(t, wfv1.NodeSucceeded, wf.Status.Nodes["2"].Phase) - assert.Equal(t, wfv1.NodeRunning, wf.Status.Nodes["3"].Phase) + assert.Equal(t, wfv1.NodeSucceeded, wf.Status.Nodes["1"].Phase) + assert.Equal(t, wfv1.NodeRunning, wf.Status.Nodes["continue-on-failed-workflow"].Phase) assert.Equal(t, 4, len(podsToDelete)) } }