From b06ce13d967af3997c5bdd6a82aaedcda502ff50 Mon Sep 17 00:00:00 2001 From: vadasambar Date: Fri, 25 Aug 2023 17:36:58 +0530 Subject: [PATCH] docs: re-word the TODO with more details Signed-off-by: vadasambar --- workflow/executor/resource.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/workflow/executor/resource.go b/workflow/executor/resource.go index f1522fa3cf1b..9b91691e2eca 100644 --- a/workflow/executor/resource.go +++ b/workflow/executor/resource.go @@ -373,7 +373,8 @@ func runKubectl(args ...string) ([]byte, error) { var buf bytes.Buffer if err := kubectlcmd.NewKubectlCommand(kubectlcmd.KubectlOptions{ Arguments: args, - // TODO(vadasambar): re-visit this once https://github.com/kubernetes/kubernetes/pull/120024 is merged + // TODO(vadasambar): use `DefaultConfigFlags` variable from upstream + // as value for `ConfigFlags` once https://github.com/kubernetes/kubernetes/pull/120024 is merged ConfigFlags: genericclioptions.NewConfigFlags(true). WithDeprecatedPasswordFlag(). WithDiscoveryBurst(300).