You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When Argo fails to run an onExit handler in a workflow, it never marks the workflow as finished, even if all the nodes in it are fulfilled.
Expected: the workflow is marked as errored.
Diagnostics
What Kubernetes provider are you using?
EKS 1.19, kind v0.10.0
What version of Argo Workflows are you running?
3.0.2
Paste a workflow that reproduces the bug, including status:
# kubectl get wftmpl -o yaml test-exit-handlerapiVersion: argoproj.io/v1alpha1kind: WorkflowTemplatemetadata:
name: test-exit-handlernamespace: testspec:
entrypoint: argosayonExit: exit-handlertemplates:
- name: argosaycontainer:
name: mainimage: 'argoproj/argosay:v2'command:
- /argosayargs:
- echo
- hello argo
- name: exit-handlertemplateRef:
name: nonexistenttemplate: exit-handler# The bug only manifests when the workflow is created via workflowTemplateRef.# kubectl get wf -o yaml test-exit-handlerapiVersion: argoproj.io/v1alpha1kind: Workflowmetadata:
generateName: test-exit-handler-namespace: testspec:
workflowTemplateRef:
name: test-exit-handler
Paste the logs from the workflow controller:
These entries show up in the logs every 30 minutes after the workflow is created:
It appears that upon encountering an error during the execution of the onExit template, the operator() function simply exits and never actually marks the workflow as an error.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered:
Think you tagged the wrong Jesse. Here it is @jessesuen
My two cents: +1 to fail the workflow in this case. An analogue to this is the finally block in Python which would raise exception as well if there's any.
Summary
What happened/what you expected to happen?
When Argo fails to run an
onExit
handler in a workflow, it never marks the workflow as finished, even if all the nodes in it are fulfilled.Expected: the workflow is marked as errored.
Diagnostics
What Kubernetes provider are you using?
EKS 1.19, kind v0.10.0
What version of Argo Workflows are you running?
3.0.2
Paste a workflow that reproduces the bug, including status:
Paste the logs from the workflow controller:
These entries show up in the logs every 30 minutes after the workflow is created:
It appears that upon encountering an error during the execution of the
onExit
template, theoperator()
function simply exits and never actually marks the workflow as an error.Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: