Add ability to pass pod annotations and labels at the template level #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2018 15:48
**What** - Add ability to set `template.metadata.annotations` and `template.metadata.labels` as pod metadata **Why** Labels are helpful when searching for k8s resources. Annotations are another type of metadata k8s supports. They can be used by various tools like [kube2iam](https://github.com/jtblin/kube2iam). **Testing** Add metadata to templates. Submit job. Test annotations and labels were added with `kubectl describe pod <pod-name>`. See `examples/pod-metadata.yaml`.
wookasz
changed the title
wookasz
changed the title
wookasz
force-pushed
the
wookasz/ch8116/add-pod-annotations-and-labels-to-argo
branch
from
1d677af to
284502b
Compare
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
template.metadata.annotationsandtemplate.metadata.labelsas pod metadataWhy
Labels are helpful when searching for k8s resources.
Annotations are another type of metadata k8s supports. They can be used by various tools like kube2iam.
Addresses #781 at least partially
Testing
Add metadata to templates. Submit job. Test annotations and labels were added with
kubectl describe pod <pod-name>. Seeexamples/pod-metadata.yaml.