chore(deps): bump golangci-lint to v1.49.0 #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
blkperl
commented
Sep 21, 2022
| - typecheck | ||
| - unparam | ||
| - unused | ||
| - varcheck |
There was a problem hiding this comment.
These three removed linters have been replaced by unused which is enabled
blkperl
commented
Sep 21, 2022
blkperl
commented
Sep 21, 2022
Comment on lines
+63
to
+65
| exclude-rules: | ||
| - path: server/artifacts/artifact_server_test.go | ||
| text: "response body must be closed" |
There was a problem hiding this comment.
I think this was a false positive but let me know if there is an easy way to fix.
There was a problem hiding this comment.
Is it flaky or consistent?
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
blkperl
added
the
type/dependencies
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
terrytangyuan
approved these changes
Sep 25, 2022
chenyangxueHDU
pushed a commit
to chenyangxueHDU/argo
that referenced
this pull request
Sep 29, 2022
* chore(deps): bump golangci-lint to v1.49.0 Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: lint newlines Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: remove extra newline Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: Address feedback Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: typo Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
* chore(deps): bump golangci-lint to v1.49.0 Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: lint newlines Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: remove extra newline Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: Address feedback Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> * fix: typo Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> Signed-off-by: juchao <juchao@coscene.io>
agilgur5
added
go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: William Van Hevelingen william.vanhevelingen@acquia.com
This resolves the following error on golang 1.19