New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Pending in NodePhases #525

Closed
jessesuen opened this Issue Dec 3, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@jessesuen
Contributor

jessesuen commented Dec 3, 2017

We currently transition directly from no phase to Running after a pod has been scheduled, which simplifies our node state machine. However, the Running phase hides the fact that a pod may be unschedulable, and is still Pending. This issue is to incorporate the Pending pod phase so that it is apparent that a pod was created but not yet running.

NOTE: "virtual" nodes like step groups, would not use the Pending phase and would continue to transition directly to Running. Only leaf nodes (i.e. pods) would make use of Pending.

@pratulw pratulw added this to the M13 milestone Dec 4, 2017

@gaganapplatix gaganapplatix self-assigned this Dec 8, 2017

@jessesuen jessesuen removed this from the M13 milestone Jan 11, 2018

@jessesuen jessesuen added this to the v2.2 milestone Aug 22, 2018

@jessesuen jessesuen assigned jessesuen and unassigned gaganapplatix Aug 22, 2018

@jessesuen

This comment has been minimized.

Contributor

jessesuen commented Aug 22, 2018

Example outputs of new Pending phase:

$ argo get pod-limits-7pxjd
Name:                pod-limits-7pxjd
Namespace:           default
ServiceAccount:      default
Status:              Running
Created:             Tue Aug 21 17:13:31 -0700 (22 seconds ago)
Started:             Tue Aug 21 17:13:31 -0700 (22 seconds ago)
Duration:            22 seconds
Parameters:
  limit:             10

STEP                    PODNAME                      DURATION  MESSAGE
 ● pod-limits-7pxjd
 ├---✔ gen-number-list  pod-limits-7pxjd-4271121940  7s
 └-·-✔ run-pod(0:1)     pod-limits-7pxjd-888908971   6s
   ├-✔ run-pod(1:2)     pod-limits-7pxjd-1445873513  7s
   ├-✔ run-pod(2:3)     pod-limits-7pxjd-885794523   6s
   ├-◷ run-pod(3:4)     pod-limits-7pxjd-1672831789  13s       ContainerCreating
   ├-◷ run-pod(4:5)     pod-limits-7pxjd-4018617467  13s       ContainerCreating
   ├-◷ run-pod(5:6)     pod-limits-7pxjd-2713948161  13s       ContainerCreating
   ├-● run-pod(6:7)     pod-limits-7pxjd-2941735403  13s
   ├-◷ run-pod(7:8)     pod-limits-7pxjd-1369060285  13s       ContainerCreating
   ├-✔ run-pod(8:9)     pod-limits-7pxjd-1321697003  9s
   └-✔ run-pod(9:10)    pod-limits-7pxjd-3434540732  8s

Example with ImagePullBackOff and message extracted from the pod

$ argo get image-pull-fail-tb57d
Name:                image-pull-fail-tb57d
Namespace:           default
ServiceAccount:      default
Status:              Running
Created:             Tue Aug 21 17:25:07 -0700 (5 seconds ago)
Started:             Tue Aug 21 17:25:07 -0700 (5 seconds ago)
Duration:            5 seconds

STEP                      PODNAME                DURATION  MESSAGE
 ◷ image-pull-fail-tb57d  image-pull-fail-tb57d  5s        ImagePullBackOff: Back-off pulling image "alpine:doesntexist"
@jessesuen

This comment has been minimized.

Contributor

jessesuen commented Aug 22, 2018

Implemented in 09f0591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment