fix(doc strings): Fix bug related documentation/clean up of default configurations #2331

[NikeNano]

Bug fix for the last comments here #2331 (review) which were not fixed before master.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
• Optional. I've added My organization is added to the README.
• I've signed the CLA and required builds are green.

[NikeNano]

FYI simster7 PR with your requested changes from #2331

[simster7]

Thanks @NikeNano! One quick change needed

[simster7]

LGTM, thanks @NikeNano! Can I encourage you to look at our help wanted issues and keep contributing? 😄

[NikeNano]

LGTM, thanks @NikeNano! Can I encourage you to look at our help wanted issues and keep contributing? 😄

Yeah, I will continue to contribute :)

[codecov]

Codecov Report

Merging #2388 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   13.13%   13.13%           
=======================================
  Files          72       72           
  Lines       25084    25084           
=======================================
  Hits         3294     3294           
  Misses      21375    21375           
  Partials      415      415

Impacted Files	Coverage Δ
workflow/config/config.go	33.33% <ø> (ø)	⬆️
workflow/controller/controller.go	2.5% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e11fc...4207a30. Read the comment docs.

[alexec]

I think we should have a page under /docs telling people how to use this and provide some examples.

[simster7]

I think we should have a page under /docs telling people how to use this and provide some examples.

Agreed... @NikeNano would you own this?

[NikeNano]

I think we should have a page under /docs telling people how to use this and provide some examples.

Agreed... @NikeNano would you own this?

Sure, I will work on this!

[alexec]

Great! Docs will encourage people to try the feature out. It might be worth while adding stability icon (e.g. alpha) and version (v2.7), example:

https://github.com/argoproj/argo/blob/master/docs/workflow-archive.md