New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass pod annotations and labels at the template level #798

Merged
merged 4 commits into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@wookasz
Contributor

wookasz commented Mar 16, 2018

What

  • Add ability to set template.metadata.annotations and template.metadata.labels as pod metadata

Why
Labels are helpful when searching for k8s resources.

Annotations are another type of metadata k8s supports. They can be used by various tools like kube2iam.

Addresses #781 at least partially

Testing
Add metadata to templates. Submit job. Test annotations and labels were added with kubectl describe pod <pod-name>. See examples/pod-metadata.yaml.

wookasz added some commits Mar 13, 2018

Add ability to pass pod annotations and labels at the template level
**What**
- Add ability to set `template.metadata.annotations` and `template.metadata.labels` as pod metadata

**Why**
Labels are helpful when searching for k8s resources.

Annotations are another type of metadata k8s supports. They can be used by various tools like [kube2iam](https://github.com/jtblin/kube2iam).

**Testing**
Add metadata to templates. Submit job. Test annotations and labels were added with `kubectl describe pod <pod-name>`. See `examples/pod-metadata.yaml`.

@wookasz wookasz changed the title from Add ability to pass pod annotations and labels at the template level to WIP: Add ability to pass pod annotations and labels at the template level Mar 17, 2018

@wookasz wookasz changed the title from WIP: Add ability to pass pod annotations and labels at the template level to Add ability to pass pod annotations and labels at the template level Mar 17, 2018

@alexmt

alexmt approved these changes Mar 19, 2018

LGTM.

Thank you for implementing it @wookasz !

@alexmt alexmt merged commit 3b2c426 into argoproj:master Mar 19, 2018

1 check passed

default Argo CI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment