Skip to content

Tuple item leading zeroes #470 - #510

Merged
sbillig merged 2 commits into
argotorg:masterfrom
andy-ow:tupple_item_leading_zeroes_#470
Aug 11, 2021
Merged

Tuple item leading zeroes #470#510
sbillig merged 2 commits into
argotorg:masterfrom
andy-ow:tupple_item_leading_zeroes_#470

Conversation

@andy-ow

@andy-ow andy-ow commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

What was wrong?

issue #470
Leading zeros in tuple indexes should not be allowed.

How was it fixed?

Check for leading zeros in tuple indexes (like item00 or item001). Small change in expressions.rs + tests.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@sbillig

sbillig commented Aug 11, 2021

Copy link
Copy Markdown
Collaborator

@andy-ow Looks great, thanks! Could you add a simple newsfragments/510.bugfix.md describing what was fixed? (Add a trailing newline on that file, or the lint check will reject it, btw)

There's also a minor conflict with the master branch now that I've merged #509. Would you mind rebasing?

@g-r-a-n-t g-r-a-n-t changed the title Tupple item leading zeroes #470 Tuple item leading zeroes #470 Aug 11, 2021
@sbillig

sbillig commented Aug 11, 2021

Copy link
Copy Markdown
Collaborator

@andy-ow I handled the chores I mentioned above; you weren't taking too long, I'd just like to get this PR merged in prior to #468, which would have caused a lot more merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants