Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign execute permission to tools/build #31

Merged
merged 1 commit into from Apr 11, 2019

Conversation

@unasuke
Copy link
Contributor

commented Apr 11, 2019

We should run tools/build to generate amalgamation source code but that script has no execute permission.

It's a bit consuming to "chmod +x" for example udzura/mruby-argtable#6

We should run tools/build to generate amalgamation source code
but that script has no execute permission.
It's a bit consuming to "chmod +x"
@tomghuang tomghuang merged commit 7a62d1a into argtable:master Apr 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomghuang

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@unasuke I didn't know that Git can keep the execute permission when we check in the code. Thank you for this pull request, which lets me know more about Git.

@unasuke unasuke deleted the unasuke:executable-tools-build branch Apr 11, 2019
@unasuke

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@tomghuang Thanks! I cloned the repository after this merged, that's executable!

Screenshot from 2019-04-11 17-25-49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.