New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations not working when importing from NPM #431
Comments
|
give this setup a quick look? I just put it together to make sure the animation is working smoothly. |
|
looks like a typo in the import: |
Thank you for pointing this out! Unfortunately this was just a typo in the GH issue (my apologies for that). In my actual project I have |
Thank you! My project is not using post-css (I'm not familiar with it). It looks like your example is though. I replicated the issue using a similar setup to mine on stackblitz: https://stackblitz.com/edit/solidjs-templates-bvinbp?file=src%2FApp.tsx You can see that the animation doesn't work by default, but if you uncomment the link tag to include the animations stylesheet then it does work. |
|
that's strange tho, when importing the props in App.module, the keyframes are removed (for no reason afaict). sounds like the build system trying to be helpful, but instead it's over doin it. i'm going to close for now, since it's a specific issue with that build process and not the files on npm/cdn. do share if you find the cause tho! |
|
Ah, I see. That's odd. |
Thanks for the great library!
I think I'm encountering a similar issue to #102 in my Vite (SolidJS) project. I have installed open-props via npm and if I import like this:
animations do not work (elements with e.g.
animation: var(--animation-shake-y);don't animate at all).But if I pull them from a CDN:
they work as expected.
I can work around this for now, but just want to let you know.
Thanks again!
The text was updated successfully, but these errors were encountered: