Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounce easings #430

Merged
merged 5 commits into from Oct 19, 2023
Merged

Bounce easings #430

merged 5 commits into from Oct 19, 2023

Conversation

argyleink
Copy link
Owner

fixes #429

@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@argyleink argyleink marked this pull request as ready for review October 19, 2023 17:47
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited

Visit the preview URL for this PR (updated for commit fadda50):

https://open-props--pr430-bounce-easing-ph92sldq.web.app

(expires Thu, 26 Oct 2023 18:22:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 32524ac481f54edda55dc959fa4614cf1acc8c11

Cthulahoop
Cthulahoop reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Cthulahoop Cthulahoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some updated eases that are a bit bouncier.

src/props.easing.css Outdated Show resolved Hide resolved
src/props.easing.css Outdated Show resolved Hide resolved
src/props.easing.css Outdated Show resolved Hide resolved
src/props.easing.css Outdated Show resolved Hide resolved
src/props.easing.css Outdated Show resolved Hide resolved
src/props.easing.js Outdated Show resolved Hide resolved
src/props.easing.js Outdated Show resolved Hide resolved
src/props.easing.js Outdated Show resolved Hide resolved
src/props.easing.js Outdated Show resolved Hide resolved
src/props.easing.js Outdated Show resolved Hide resolved
@argyleink @Cthulahoop
Apply suggestions from code review
fadda50 
Co-authored-by: Ric <Cthulahoop@users.noreply.github.com>
@argyleink argyleink merged commit ce8c2d3 into main Oct 19, 2023
4 checks passed
@argyleink argyleink deleted the bounce-easing branch October 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cthulahoop Cthulahoop Cthulahoop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --ease-bounce-* easings
2 participants
@argyleink @Cthulahoop