Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove Test::Exception from test requirements

While debugging on weird FAIL reports on OpenBSD, I found one case
lacking proper check, and realize that Test::Exception requirement was
maybe overkill for 2 eval/$@ checking.
  • Loading branch information...
commit 39b86c9bbb900511ecc3591c76cb00d8d9ab075d 1 parent fd4f0c8
@arhuman authored
View
5 META.json
@@ -20,11 +20,6 @@
]
},
"prereqs" : {
- "build" : {
- "requires" : {
- "Test::Exception" : "0"
- }
- },
"configure" : {
"requires" : {
"ExtUtils::MakeMaker" : "0"
View
2  META.yml
@@ -2,8 +2,6 @@
abstract: 'a pure-Perl implementation of the RIPE Database client.'
author:
- 'Luis Motta Campos <lmc@cpan.org>'
-build_requires:
- Test::Exception: 0
configure_requires:
ExtUtils::MakeMaker: 0
dynamic_config: 1
View
2  Makefile.PL
@@ -22,7 +22,7 @@ WriteMakefile(
bugtracker => 'https://github.com/arhuman/Net-Whois-RIPE/issues'
},
},
- BUILD_REQUIRES => { 'Test::Exception' => 0, },
+ BUILD_REQUIRES => { },
dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', },
clean => { FILES => 'Net-Whois-RIPE-*' },
);
View
17 t/02-methods.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
@@ -97,7 +96,8 @@ SKIP: {
ok $c->is_connected, 'The client is connected.';
# reconnect()
- lives_ok { $c->reconnect } 'The client re-connected without dying.';
+ eval {$c->reconnect };
+ ok !$@,'The client re-connected without dying.';
ok $c->is_connected, 'The client is connected (once more).';
# ios()
@@ -111,17 +111,18 @@ SKIP: {
# query()
{
my $iter;
- lives_ok { $iter = $c->query('LMC-RIPE') }
- q{Client performs queries without dying};
+ eval { $iter = $c->query('LMC-RIPE') };
+ ok !$@, q{Client performs queries without dying};
isa_ok $iter, 'Iterator';
+ last unless $iter;
ok $iter->isnt_exhausted, q{Iterator contains at least one result};
}
# object_types()
{
my @types;
- lives_ok { @types = $c->object_types }
- q{Client can retrieve available object types without dying.};
+ eval { @types = $c->object_types };
+ ok !$@ , q{Client can retrieve available object types without dying.};
is $#types, 20,
q{There are 21 known object types in the RIPE Database};
}
@@ -129,9 +130,9 @@ SKIP: {
# send()
# disconnect()
- lives_ok { $c->disconnect } 'The client disconnected without dying.';
+ eval { $c->disconnect };
+ ok !$@ , 'The client disconnected without dying.';
ok !$c->is_connected, 'The client is not connected (anymore).';
# DESTROY()
}
-
View
1  t/03-objects.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/105-AsBlock.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
# use IO::Handle;
View
1  t/110-AutNum.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
use Net::Whois::Object;
# synchronizes the {error,standard} output of this test.
View
1  t/115-Person.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/120-Role.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/125-AsSet.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/130-Domain.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/135-InetNum.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/140-Inet6Num.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/145-InetRtr.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/150-RtrSet.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/155-Mntner.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/160-KeyCert.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/165-Route.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/167-Route6.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/170-RouteSet.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/175-PeeringSet.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/180-Limerick.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/185-Poem.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/187-PoeticForm.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/190-Organisation.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/195-Response.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/200-Information.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/205-Irt.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/210-FilterSet.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More qw( no_plan );
-use Test::Exception;
# synchronizes the {error,standard} output of this test.
use IO::Handle;
View
1  t/215-SyncUpdates.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More;
-use Test::Exception;
use Net::Whois::RIPE;
use Net::Whois::Object;
View
1  t/216-SyncUpdates-Signed.t
@@ -1,7 +1,6 @@
use strict;
use warnings;
use Test::More;
-use Test::Exception;
use Net::Whois::RIPE;
use Net::Whois::Object;
Please sign in to comment.
Something went wrong with that request. Please try again.