Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

refactor remove deprecated usage of expandos in DomElementWrapper

DomElementWrapper.getData() no longer internally checks for expandos
prefixed with '_'. Please use 'data-' prefix for expandos.

Most of the related code was removed in AT 1.3.1, this is just leftovers
that were omitted that time.
  • Loading branch information...
commit b88bc5173c227746af98dc6fab20f58235f8c164 1 parent 4ec904a
@jakub-g jakub-g authored divdavem committed
Showing with 3 additions and 11 deletions.
  1. +3 −11 src/aria/templates/DomElementWrapper.js
View
14 src/aria/templates/DomElementWrapper.js
@@ -93,20 +93,12 @@ Aria.classDefinition({
this.$logError(this.INVALID_EXPANDO_NAME, [dataName]);
return null;
}
- // expandoKey is deprecated. To be removed.
- var expandoKey = '_' + dataName;
var dataKey = 'data-' + dataName;
- var attribute = domElt.attributes[expandoKey] || domElt.attributes[dataKey];
- if (domElt.attributes[expandoKey] != null) {
- this.$logWarn("The '_' usage is deprecated for the expando %1, please use the dataset html attribute instead.", [expandoKey]);
- }
+ var attribute = domElt.attributes[dataKey];
if (!attribute && checkAncestors) {
var parent = domElt.parentNode;
while (!attribute && parent != null && parent.attributes != null) {
- attribute = parent.attributes[expandoKey] || parent.attributes[dataKey];
- if (domElt.attributes[expandoKey] != null) {
- this.$logWarn("The '_' usage is deprecated for the expando %1, please use the dataset html attribute instead.", [expandoKey]);
- }
+ attribute = parent.attributes[dataKey];
parent = parent.parentNode;
}
}
@@ -352,4 +344,4 @@ Aria.classDefinition({
getScroll : function () {},
setScroll : function (scrollPositions) {}
}
-});
+});
Please sign in to comment.
Something went wrong with that request. Please try again.