Permalink
Switch branches/tags
Commits on Feb 3, 2017
  1. fix/test #1753 fixing issues in tests following #1749

    divdavem committed Feb 3, 2017
    This commit fixes test issues which are happening following commit
    8432f5b from #1749:
    - SelectOnBlurSimpleRobotTestCase fails on Safari because a <select> in
    Safari (on Mac) behaves differently than in other browsers (on Windows):
    pressing the down arrow key opens the dropdown instead of only changing
    the selection, as it is expected in the test
    This test is now excluded from the test campaign for Safari.
    - OpenDropDownFromButtonTestCase fails on IE 8 because SynEvents does not
    faithfully reproduces the behavior of IE 8
    This test was replaced by a robot test which correctly tests what is really
    happening on IE 8
Commits on Jan 31, 2017
  1. fix/test #1752 Removed unnecessary assert in test.aria.widgets.errorl…

    ymeine committed Jan 31, 2017
    …ist.displayOptions.ErrorListDisplayOptionsTestCase (#1752)
    
    This was an unnecessary double check, which moreover was not properly implemented to work in IE8.
Commits on Jan 30, 2017
  1. feat #1751 ErrorList widget: now custom displayOptions can be passed …

    ymeine committed Jan 30, 2017
    …to the template (#1751)
    
    Now the template used by the widget will have a displayOptions property in its data model, as defined by the user inside the ErrorList widget instance's configuration under the homonym property.
Commits on Jan 24, 2017
  1. feat #1749 Adding the onblur event on the Select widget

    divdavem committed Jan 24, 2017
    This commit also adds some fixes to make sure there is no blur event when
    clicking on the dropdown icon or when clicking on an option in the list.
    
    close #1749
    PTR 12092520
    AT-1657
Commits on Jan 18, 2017
  1. feat #1748 Avoid refreshing dialog content after a resize

    divdavem committed Jan 18, 2017
    This commit removes the refresh which happens after resizing a dialog.
    
    close #1748
    AT-1642
Commits on Jan 12, 2017
  1. fix #1747 Dropdown icons no longer focusable when the widget is disabled

    divdavem committed Jan 12, 2017
    This commit removes the "tabindex" attribute and adds the "aria-hidden"
    attribute on the dropdown icon of widgets when they are disabled.
    
    AT-1625
Commits on Dec 16, 2016
  1. 1.8.1

    divdavem committed Dec 16, 2016
  2. fix/test #1746 excluding failing tests on IE 9

    divdavem committed Dec 16, 2016
    The following 3 tests were successful in 1.7.21 and started to fail in 1.7.22:
     - test.aria.html.textinput.placeholder.PlaceholderTestCase
     - test.aria.widgets.dropdown.touchDevices.AutoCompleteNoExpButPopupDesktopRobotTestCase
     - test.aria.widgets.dropdown.touchDevices.AutoCompleteNoExpButPopupTouchRobotTestCase
    
    This commit excludes them from the test campaign on IE 9 until they are fixed.
    
    close #1746
Commits on Dec 15, 2016
  1. fix #1745 (#1745)

    fbasso committed Dec 15, 2016
    test.aria.widgets.container.dialog.closePopupScroll.ClosePopupScrollRobotTestCase
    failed with chrome 55
  2. fix/test #1743 Missing call to $dispose on DomElementWrapper

    divdavem committed Dec 15, 2016
    Following commit 925c907, the call to
    $dispose on DomElementWrapper objects returned by $getElementById is no
    longer done automatically. This commit adds a missing call to $dispose on
    a DomElementWrapper instance in a Jaws test case.
  3. fix #1742 Regression in linkItfWrappers after refactoring interface w…

    divdavem committed Dec 15, 2016
    …rappers
    
    Commit ff7921e from #1736 introduced a
    regression in the linkItfWrappers function on modern browsers (which have
    an implementation of WeakMap).
    As a consequence, test.aria.modules.moduleReload.ModuleReload1TestCase and
    test.aria.modules.moduleReload.ModuleReload2TestCase fail on those browsers.
    This commit fixes this regression.
Commits on Dec 14, 2016
  1. feat #1741 Adding the waiOpenMsg property on the aria:Dialog widget

    divdavem committed Dec 14, 2016
    The new waiOpenMsg property allows to specify a message to be read by
    screen readers when the dialog is opened.
    
    close #1741
    AT-1611
  2. fix #1740 Improving error logging in the JsonValidator

    tjw02 committed with divdavem Dec 14, 2016
    When there is an error coming from the JsonValidator, the details of the error are now part of the error message, instead of being available only inside the "errors" property, that was not directly displayed in the console.
    
    close #1049
Commits on Dec 9, 2016
  1. fix #1739 memory leak when calling $getElementById or $getChild on a …

    divdavem committed Dec 9, 2016
    …template
    
    Each time a call to $getElementById or $getChild is done on a template,
    a new DomElementWrapper object is created and, until this commit,
    the wrapper was also added to an array in the template context, with the
    only purpose of calling $dispose on all wrapper elements when
    the template is fully refreshed or disposed. If this does not happen
    (e.g. if there are only partial refreshes), and many calls to the
    $getElementById and $getChild functions are done, this creates a leak.
    With this commit, wrappers are no longer stored on the template context,
    it is up to the application to dispose them (if needed).
Commits on Dec 7, 2016
  1. feat/test #1720 Updating dependencies

    divdavem committed Dec 7, 2016
    close #1720
Commits on Dec 6, 2016
  1. fix #1737 easypackage and atbuild grunt tasks issue with npm3

    divdavem committed Dec 6, 2016
    This commit fixes an issue with the easypackage and atbuild grunt tasks
    when using npm3 with its flat folder structure (the getModulePath function
    expects Aria Templates dependencies to be in the node_modules folder in
    the ariatemplates folder, but they could actually be upper in the folder
    structure).
    
    close #1738
Commits on Dec 5, 2016
  1. feat #1735 WAI-ARIA - Processing Indicator - Added tab management for…

    ymeine committed Dec 5, 2016
    … processing indicators (#1735)
    
    Now elements with a processing indicator on top of them are inaccessible also with the tab key.
    
    AT-1540
    
    close #1735
Commits on Dec 2, 2016
  1. fix #1736 Changing implementation of interface wrappers to avoid leaks

    divdavem committed Dec 2, 2016
    If an object for which an interface wrapper has been created is never
    disposed through its $dispose method, the garbage collector can never
    collect it because the corresponding interface keeps a reference to it.
    
    For example, assuming the x.Y class impements the x.IY interface,
    the following code creates a leak:
    
     for (var i = 0; i < 100000; i++) {
        var myObj = new x.Y();
        myObj.$interface("x.IY");
        // The leak would not appear if myObj was disposed like this:
        // myObj.$dipsose();
     }
    
    This commit avoids creating a leak in such a case by using a WeakMap
    in the interface in order to keep a reference to the underlying object
    without preventing the garbage collector from collecting the underlying
    object and interface wrapper if there is no other reference to them
    anywhere.
    (in case the browser does not support WeakMap, an equivalent alternative
    implementation is used)
    
    AT-1602
    PTR 12602212
Commits on Nov 29, 2016
  1. feat #1734 Injecting DomEventWrapper in TextInput:onclick

    divdavem committed Nov 29, 2016
    Before this commit, the onclick event handler of the TextInput-based
    widgets did not receive any event object. This commit makes sure a
    DomEventWrapper object is passed to the event handler, as it is done
    in other widgets.
    
    PTR 11315120
    AT-1344
    close #1734
Commits on Nov 24, 2016
  1. fix/test #1732 Removing specific versions of Chrome and Firefox in te…

    divdavem committed Nov 24, 2016
    …st config
    
    This avoids having to update the repository for each new version of those
    browsers.
    
    close #1732
Commits on Nov 23, 2016
  1. feat #1731 Adding the focusableWhenDisabled parameter on aria:Button …

    divdavem committed Nov 23, 2016
    …widgets
    
    Blind users often navigate in a page with tab, which means they cannot
    notice disabled widgets, which are not focusable.
    When those widgets are essential to understand the page, this is a problem,
    especially for buttons. This commit allows important buttons to be
    focusable when they are disabled, by setting the focusableWhenDisabled
    parameter to true.
    
    AT-1593
    close #1731
  2. feat #1724 Raising an event when a new parent is added in the 'aria:p…

    vcarle committed with divdavem Nov 23, 2016
    …arent' property of a node
    
    This commit adds a new global `aria-parent-metadata-added` event
    in `aria.utils.Json` which notifies that a new parent has been added
    in the `aria:parent` property of a node of the datamodel.
    
    This can help detecting potential memory leak issues with `aria:parent`
    properties being added in the datamodel, but never removed.
    
    close #1713 
    close #1724
Commits on Nov 21, 2016
  1. feat #1730 Adding a focusable element at the top of the TabPanel widget

    divdavem committed Nov 21, 2016
    This focusable element is only added when waiAria is true, and has the
    same aria-labelledby attribute as the root element of the tab panel,
    so that, when focusing the tab panel, the title of the currently selected
    tab is read by screen readers.
    
    AT-1580
    close #1730
Commits on Nov 17, 2016
  1. fix/test #1729 Fixed test.aria.utils.accessibility.AccessibilityJawsT…

    ymeine committed Nov 17, 2016
    …estCase (#1729)
    
    In some testing environments, the screen reader has to read multiple things, so it's better to wait longer so that everything is read properly.
    
    close #1729
  2. fix #1728 Short months in Thai were not set properly (#1728)

    fbasso committed Nov 17, 2016
    PTR 12371609
  3. Revert "feat #1721 WAI-ARIA - ActionWidget - Implement aria-hidden (w…

    ymeine committed Nov 17, 2016
    …aiLabelHidden)" (#1727)
    
    This reverts commit c250e2f.
    
    It seems that the change was actually not necessary.
    
    close #1727
  4. fix #1726 - WAI-ARIA - DatePicker - Date was read even with keystroke…

    ymeine committed Nov 17, 2016
    …s not changing text (#1726)
    
    An internal variable was not properly used to implement the feature, the fix was trivial. Test has been enhanced to check this use case.
    
    close #1726
  5. fix #1725 Removing role="button" and adding a tabindex on dropdown icons

    divdavem committed Nov 17, 2016
    This commit removes the role="button" attribute and adds a tabindex on the
    dropdown icon of the widgets which extend DropDownTextInput (DatePicker,
    MultiSelect...), so that those icons are not included in the list of
    buttons displayed by screen readers and become focusable by tab.
    
    AT-1582
Commits on Nov 10, 2016
  1. feat #1723 WAI-ARIA - Processing Indicator - Implement processing ind…

    ymeine committed Nov 10, 2016
    …icators (#1723)
    
    Now processing indicators - on elements and sections - can be accessible, the loading message being repeated every X seconds (by default 2) and the elements under the indicator being hidden the time it is active.
    
    AT-1540
    
    close #1723
Commits on Nov 9, 2016
  1. feat #1721 WAI-ARIA - ActionWidget - Implement aria-hidden (waiLabelH…

    ymeine committed Nov 9, 2016
    …idden) (#1721)
    
    Now it is possible to set waiLabelHidden for all ActionWidget based widgets, in order to put the attribute aria-hidden around their actual (visual) label element.
    
    AT-1571
    PTR 12373188
    
    close #1721
Commits on Nov 7, 2016
  1. fix #1722 Removing the "tab" role for @aria:Tab

    divdavem committed Nov 7, 2016
    Blind users do not like the "tab" role because, just as the "application"
    role, it prevents them from using their navigation shortcuts. This commit
    simply removes the role attribute for tabs, and also adds the href
    attribute on the anchors so that tabs are recognized as links.
Commits on Oct 25, 2016
  1. fix #1719 Skip updating manually hidden dialogs on viewport resize

    divdavem committed Oct 25, 2016
    If a dialog is manually hidden (by setting its display CSS property
    to "none" and by updating the corresponding isOpen boolean on the
    popup object), its size will no longer be updated on viewport resize.
    This avoids setting the size of the popup to 0 (as offsetWidth
    and offsetHeight can return 0 for elements which are not visible on the
    screen).
    
    AT-1558
    PTR 12308453
Commits on Oct 24, 2016
  1. refactor #1718 aria.utils.Bridge now uses aria.utils.FrameATLoader

    divdavem committed Oct 24, 2016
    aria.utils.Bridge now relies on aria.utils.FrameATLoader to load Aria
    Templates in the popup window instead of relying on its own implementation
    (which reduces duplication in the framework).
    
    There is now a new crossDomain option in aria.utils.FrameATLoader
    to use document.write instead of loading FrameATLoaderHTML.html, which
    makes FrameATLoader work in case Aria Templates is loaded from a different
    origin (such as cdn.ariatemplates.com).
    However, when this option is set to true, changing the hash in the popup
    causes issues on Firefox 3 and 11, so it is false by default.
    
    Calls to document.write to load a script, are now removed, as these
    calls can be blocked on Chrome in some cases, as documented in the
    following document:
    https://developers.google.com/web/updates/2016/08/removing-document-write
    
    This commit fixes BridgeTestCase on IE 9.
    It also fixes the crash which occured when closing Aria Templates debug
    tools (due to an endless recursive call).
    
    close #1718