Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on May 5, 2015
  1. @jakub-g

    fix #1468 Prefix URLs in CSS templates feature not working

    jakub-g authored
    Feature implemented in #972 did not work due to invalid CSS
    generated: a space between `url` keyword and the parentheses
    made the whole CSS rule invalid and hence not applied
Commits on Apr 22, 2015
  1. @jakub-g

    fix #1452 Classic Test Runner: explicitly declare wlibs

    jakub-g authored
    Explicitly declare dependencies so that an application
    using the runner does not need to depend on AriaLib
    in order to run the tester
    See attester/attester#124
Commits on Apr 2, 2015
  1. @jakub-g
Commits on Mar 20, 2015
  1. @jakub-g

    fix #1411 Classic Test Runner: load extrascripts in isolated mode

    jakub-g authored
    This commit adds the possibility to load in the Classic Test Runner
    the extrascripts exposed in attester's config, when CTR is run
    in isolated mode.
    Previously, the extrascripts were injected by attester only to CTR's
    index page, but CTR had no possibility to propagate those scripts
    into the iframe when tests were run with `#runIsolated=true` in the URL.
    This commit needs attester/attester#121
    integrated in attester (to be released in attester 2.2.0)
    in order for it to properly expose `before` and `after` extrascripts.
    Close #1411
  2. @jakub-g
  3. @jakub-g

    fix #1411 Classic Test Runner: make iframe semi-transparent

    jakub-g authored
    This commit makes an iframe used to run the test in Classic Test Runner
    in isolated mode semi-transparent, in order to easily follow the progress
    of the test suite, which happens in background.
Commits on Jan 21, 2015
  1. @jakub-g

    fix #1377 loading overlay juddering on scroll in Safari Mobile

    jakub-g authored
    Since overlay implementation was using fixed positioning,
    the user experience was not very good in Safari Mobile
    (e.g. on ipad) because the browser doesn't do repaints
    of fixed-positioned elements during scrolling.
    The implementation of overlay was changed to use equivalent
    absolute positioning instead.
    This commit is an improved version of
    which was reverted in
    The changes since original commit were:
    1) fixed ScrollableBodyTest regression causing the loading overlay
    not to be displayed when page was scrolled too far
    2) fixed loading overlay position when element was out of viewport:
    When overlay's parent element was partially out of viewport
    (on its top/left), overlay's position was badly calculated
    (it was positioned too much towards the top/left).
    Close #1386
  2. @jakub-g

    fix #1377 `Dom.getViewportSize` on tablets

    jakub-g authored
    `aria.utils.Dom.getViewportSize` was not reporting
    proper values on tablets. It was reporting virtual viewport
    size instead of screen-available viewport size:
    1) It not taking into account viewport resize
    when the user zoomed in.
    2) In Safari on Ipad, it was not taking into account the fact
    that the viewport expands on user scroll (due to address bar
    Close #1386
Commits on Jan 16, 2015
  1. @jakub-g

    fix #1391 run Phantom-unfriendly tests also in Travis

    jakub-g authored
    Some tests were never run locally due to some issues with PhantomJS.
    This PR makes `npm test` run those tests with Chrome / Firefox
    via Selenium Java Robot.
Commits on Jan 13, 2015
  1. @jakub-g
Commits on Jan 12, 2015
  1. @jakub-g


    jakub-g authored
  2. @jakub-g

    Revert "fix #1377 loading overlay juddering on scroll in Safari Mobile"

    jakub-g authored
    This reverts commit 2aa83bb.
    The commit was found to cause regressions. It will be integrated
    with the proper fixes later via #1386.
Commits on Jan 8, 2015
  1. @jakub-g

    refactor/remove: TestIdsTestCase.html

    jakub-g authored
    The file is not useful, the test can be launched via
    Close #1376
  2. @jakub-g

    refactor/remove: iframeLoaderOs

    jakub-g authored
    iframeLoaderOs and iframeIndexOs were unused since
    GH-471 landed (v1.4.4)
  3. @jakub-g

    remove compat: boolean param for sync requests in submitJsonRequest

    jakub-g authored
    Removed backward compatibility in
    `aria.templates.ModuleCtrl.submitJsonRequest` method:
    Since 1.6.2 the method accepted boolean param (at 4th position)
    which, when set to `false`, made the request synchronous.
    This was deprecated in 1.6.7 in favor of passing an object with
    options, which is more versatile and apart from setting `async` flag,
    can be used to override timeout and headers.
    In other words, if you used
        `submitJsonRequest(.., .., .., false)`
    you should use instead:
        `submitJsonRequest(.., .., .., {async: false})`
    Note that synchronous requests will freeze the UI of the browser
    and should not be used unless you have a valid use case for them.
    (deprecated in 1.6.7 via GH-1316)
  4. @jakub-g

    remove compat: `onpopstate` event from utils.History

    jakub-g authored
    Removed backward compatibility for `onpopstate` event raised by
    Use `popstate` event instead.
    (deprecated in 1.6.3 via GH-1124)
  5. @jakub-g

    remove compat: unused jsunit classes

    jakub-g authored
    Removed some `aria.jsunit.*` classes that are no longer supported.
    (deprecated in 1.5.3 via GH-1104)
  6. @jakub-g

    remove compat: `escape` modifier

    jakub-g authored
    Removed the `escape` modifier available in the templates.
    Please use `escapeforhtml` modifier instead.
    (deprecated in 1.5.3 via GH-1099)
  7. @jakub-g

    remove compat: `cssClass` in sections and repeaters

    jakub-g authored
    Removed backward compat for `cssClass` property in sections
    and repeaters. Please use `attributes.classList` instead.
    (deprecated in 1.5.2 via GH-1086)
  8. @jakub-g

    remove compat: non-standard dataset keys in utils.Html

    jakub-g authored
    Removed backward compatibility when the user was using
    non-standard dataset keys in `aria.utils.Html` methods.
    (deprecated in 1.4.7 via GH-499)
  9. @jakub-g

    remove compat: `password` property in `html:TextInput`

    jakub-g authored
    Removed the `password` config property of `html:TextInput`.
    Use `attribute.type = password` instead.
    (deprecated in 1.4.6 via GH-551)
  10. @jakub-g

    remove compat: `onEmbededElementDispose` in `embed:Element`

    jakub-g authored
    Removed backward compatibility for `onEmbededElementDispose`
    callback (note the typo) in `embed:Element` controller.
    Use `onEmbeddedElementDispose` instead.
    (deprecated in 1.4.5 via GH-535)
Commits on Jan 7, 2015
  1. @jakub-g

    fix #1382 logWarn when adding callback with undefined scope

    jakub-g authored
    We used to log a cryptic error via assert
Commits on Dec 16, 2014
  1. @jakub-g

    fix #1377 loading overlay juddering on scroll in Safari Mobile

    jakub-g authored
    Since overlay implementation was using fixed positioning,
    the user experience was not very good in Safari Mobile
    (e.g. on ipad) because the browser doesn't do repaints
    of fixed-positioned elements during scrolling.
    The implementation of overlay was changed to use equivalent
    absolute positioning instead.
  2. @jakub-g

    doc Explain aria.utils.Dom methods

    jakub-g authored
    The jsdoc didn't clearly say what kind of values should be expected
Commits on Dec 10, 2014
  1. @jakub-g

    fix #1367 use `expando.value` instead of deprecated `.nodeValue`

    jakub-g authored
    Chrome and Firefox dev tools log deprecation message of `.nodeValue`
    which may unnecessarily pollute applications' logs.
    The alternative `.value` seems to be supported by all browsers
    (tested down to Firefox 3 and IE7)
Commits on Dec 4, 2014
  1. @jakub-g

    fix #1278 onclick broken if Icon has no tooltip

    jakub-g authored
    When Icon widget had no tooltip, but `onclick` defined, the method
    was never invoked.
    The commit only removes the conditional statement around delegate
    definition (ugly diff due to whitespace change)
    close #1279
    close #1366
Commits on Nov 20, 2014
  1. @jakub-g


    jakub-g authored
  2. @jakub-g

    fix #1352 DatePickerWithValidatorTest IE7 failure

    jakub-g authored
    This fixes a new test added in 7b13250
    which was found to be failing in IE7 during release testing.
    The test was failing in IE7 due to IE7 being served a different HTML
    than other browsers (one more nested span in IE7). New test checks
    still different HTML elements in IE7 and non-IE7 browsers, though both
    of them should have an error CSS class.
Commits on Nov 19, 2014
  1. @jakub-g

    Revert "fix Select loses focus state when an item is selected"

    jakub-g authored
    This reverts commit 6443a7d.
    Reopens #1333
Commits on Nov 13, 2014
  1. @jakub-g

    doc #1337 add test showing handling of IO timeouts and 404s

    jakub-g authored
    This is mostly for documentation purposes for future reference
    (no code change inside the framework).
    Close #1337
Commits on Oct 31, 2014
  1. @jakub-g
Commits on Oct 17, 2014
  1. @jakub-g

    refactor Remove unused imports

    jakub-g authored
    With the conversion with at-noder-converter, some unused require's
    were added to the code (requires that do not save the required module
    to a variable). They can be removed.
    Note however that there are still some require's not saved into
    a variable in the code which are still needed. They are mostly:
    - requires of cfg beans
    - requires of filters
    This is because cfg beans and filters are passed to certain methods by
    their string classpath, and not by object reference.
    Close #1293.
Commits on Oct 9, 2014
  1. @jakub-g

    fix #1315 preserve amabuild in URL on test.htm

    jakub-g authored
    If someone opens a page test.htm?amabuild=true and types the classpath, the amabuild param
    is not preserved. This commit fixes that issue
Commits on Oct 6, 2014
  1. @jakub-g
Something went wrong with that request. Please try again.