Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSHint code correction needed for build: Confusing use of '!' #23

Closed
simonarbuckle opened this issue Jun 28, 2012 · 3 comments
Closed

Comments

@simonarbuckle
Copy link
Collaborator

The following warning is breaking the build and needs to be resolved by code correction:

aria/templates/NavigationManager.js jshint results

line 93, col 60, Confusing use of '!'.
line 93, col 83, Confusing use of '!'.
line 94, col 29, Confusing use of '!'.
line 94, col 54, Confusing use of '!'.
line 94, col 77, Confusing use of '!'.
line 94, col 101, Confusing use of '!'.
line 315, col 37, Confusing use of '!'.
line 315, col 73, Confusing use of '!'.
line 316, col 42, Confusing use of '!'.

aria/utils/Mouse.js jshint results

line 307, col 51, Confusing use of '!'.

aria/utils/Profiling.js jshint results

line 152, col 21, Confusing use of '!'.

aria/widgets/form/list/ListController.js jshint results

line 522, col 33, Confusing use of '!'.
line 538, col 33, Confusing use of '!'.
line 554, col 33, Confusing use of '!'.

@simonarbuckle
Copy link
Collaborator Author

I would prefer to suppress this warning but it seems it is not configurable at the moment, therefore the only other option is to correct the code.

@piuccio
Copy link
Contributor

piuccio commented Sep 4, 2012

This is related to issue 578 on jshint which is not going to be fixed anytime soon

@jakub-g
Copy link
Collaborator

jakub-g commented Oct 29, 2012

This has been fixed by commit d882661. Now in build/visitors/lint.js we can define additional JSHint errors to be ignored, if they're not configurable in JSHint itself.

@jakub-g jakub-g closed this as completed Oct 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants