Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Change the order in Travis build & make it fail fast #256

Closed
jakub-g opened this Issue · 3 comments

2 participants

jakub-g Fabio Crisci
jakub-g
Collaborator

Current Travis order:
JSHint, package, attester

New order should be:
JSHint, attester, package

Also, while invoking npm install we do the full build which doesn't make sense.

The other thing is that when there's error while loading Aria in node.js main file, we return exit code 0 (which means all's fine) which is also wrong. It has to be changed to make it possible to short-circuit execution and fail fast in the build when error spotted.

jakub-g jakub-g referenced this issue from a commit in jakub-g/ariatemplates
jakub-g jakub-g fix #256 change order in travis build
Run attester before packager. Do not do packaging on 'npm install'. Exit
early in case of errors.

Close #258.
d7b9a2d
Fabio Crisci

By the way, there's an error in package.json, grunt is marked as a devDependencies but it's used by the install script, meaning that any other package with a dependency on Aria Templates now fails to build

jakub-g
Collaborator

Good to know.

However once we remove install doing Grunt, it will not be a problem any longer.

So regarding the previous comments on the pull request, I think the most reasonable thing to do is to add prestart which will look into a local directory to see if the built version of the fwk is there, and log a warning if not. Do you agree?

Or maybe do not display a checkbox in the HTML for 'use minified code' (or make it non-editable) in that case? :)

jakub-g
Collaborator

Closed by #275

jakub-g jakub-g closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.