Dialog should have a 'maximize' button #349

Closed
jakub-g opened this Issue Jan 24, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@jakub-g
Collaborator

jakub-g commented Jan 24, 2013

@aria:Dialog should have a config option to display 'maximize / unmaximize' button.

The maximized state should persist on window resize.

jakub-g added a commit to jakub-g/ariatemplates that referenced this issue Feb 1, 2013

feat #349 maximizable dialog
Dialog can be now maximizable. If configured so, it will have a button to
maximize/unmaximize next to the Close button. It also reacts to the change
of the data model property "maximized". That property takes precedence
over center, xpos, ypos, width, height changes.

When maximized, Dialog occupies the whole viewport and is not
movable/resizable. After unmaximizing, it returns to the original
position, size and other capabilities.

Close #349. Close #358.

@piuccio piuccio closed this in 29331b1 Feb 1, 2013

jakub-g added a commit to jakub-g/ariatemplates that referenced this issue Feb 4, 2013

fix #349 maxwidth/maxheight issues in Dialog
After delivering #349 via commit 29331b1
a regresion was found during release testing: maxwidth/maxheight
constraints of the Dialog were calculated too big due to addition of the
shadow. That addition should be done only in maximized mode.

Moreover, the Dialog was not correctly resized in maximized mode when
it had maxWidth/maxHeight set. Now that properties are ignored in
maximized mode.

Close #359.

piuccio pushed a commit that referenced this issue Feb 4, 2013

fix #349 maxwidth/maxheight issues in Dialog
After delivering #349 via commit 29331b1
a regresion was found during release testing: maxwidth/maxheight
constraints of the Dialog were calculated too big due to addition of the
shadow. That addition should be done only in maximized mode.

Moreover, the Dialog was not correctly resized in maximized mode when
it had maxWidth/maxHeight set. Now that properties are ignored in
maximized mode.

Close #359.
@jakub-g

This comment has been minimized.

Show comment Hide comment
@jakub-g

jakub-g Feb 12, 2013

Collaborator

(reopen) Since not everything was delivered (missing some tests, minor bugs) in 1.3.5, I'll reuse this issue for a "service pack".

Collaborator

jakub-g commented Feb 12, 2013

(reopen) Since not everything was delivered (missing some tests, minor bugs) in 1.3.5, I'll reuse this issue for a "service pack".

jakub-g added a commit to jakub-g/ariatemplates that referenced this issue Feb 20, 2013

fix #349 maximizable Dialog service pack
Fixed issues with:
1. Dialog maximized from start
2. Resizing Dialog while maximized
3. Resizing viewport while Dialog maximized
4. Unmaximizing the Dialog after full section refresh

Additionally:
1. Perf and readability improvements (`changeProperty` vs
`setProperty`).
2. Test for destroying/creating Draggable/Resizable.

Close #383.

piuccio pushed a commit that referenced this issue Feb 20, 2013

fix #349 maximizable Dialog service pack
Fixed issues with:
1. Dialog maximized from start
2. Resizing Dialog while maximized
3. Resizing viewport while Dialog maximized
4. Unmaximizing the Dialog after full section refresh

Additionally:
1. Perf and readability improvements (`changeProperty` vs
`setProperty`).
2. Test for destroying/creating Draggable/Resizable.

Close #383.
@piuccio

This comment has been minimized.

Show comment Hide comment
@piuccio

piuccio Feb 20, 2013

Contributor

Some fixes were done in 5e7cb61 and delivered in v1.3.6 through #383

Contributor

piuccio commented Feb 20, 2013

Some fixes were done in 5e7cb61 and delivered in v1.3.6 through #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment