Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Slider widgets improvement (touch library) #713

Closed
mlaval opened this Issue Sep 9, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Owner

mlaval commented Sep 9, 2013

Several improvements and bug fixing in these widgets:

  • Slider and DoubleSlider have the same CSS class name, so there are conflicts when used in the same page
  • Both do not accept the standard attributes option, e.g
    attributes: {
    classList: ["switch"]
    },
  • tapToMove option does not work in Slider
  • Switch labels should be definable by users, instead of being hardcoded to ON and OFF
  • Highlight bar in DoubleSlider is not well filling the space when the buttons are round
  • Highlight bar should also available in Slider
Contributor

piuccio commented Sep 10, 2013

And from the developer point of view.
One of them uses

bind: {
    value: ....
}

The other one uses

bindValue: ...
Owner

mlaval commented Sep 10, 2013

Good point, to be fixed too. Let's use this one for both as most widgets are done this way:

bind: {
    value: ....
}

mlaval added a commit to mlaval/ariatemplates that referenced this issue Sep 10, 2013

mlaval added a commit to mlaval/ariatemplates that referenced this issue Sep 13, 2013

mlaval added a commit to mlaval/ariatemplates that referenced this issue Oct 3, 2013

mlaval added a commit to mlaval/ariatemplates that referenced this issue Oct 4, 2013

@mlaval mlaval closed this in 8adab6b Oct 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment