Dialog widget should have bindable width & height #80

Closed
jakub-g opened this Issue Jul 24, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Collaborator

jakub-g commented Jul 24, 2012

Currently Dialog has bindable xpos and ypos, but not width nor height.

The new feature should comply with min/max width/height.

Collaborator

jakub-g commented Sep 14, 2012

I've marked as priority:high as in fact, this should have been done with one of the previous CRs concerning dialog, but was overlooked.

vratojr was assigned Nov 6, 2012

Contributor

vratojr commented Nov 6, 2012

In progress.

Collaborator

jakub-g commented Dec 7, 2012

It will be good to write unit tests and finally finish this some day soon (perhaps I'll take it when I have more time, but other volunteers appreciated :))

BTW I've played with the Simone's code and samples, but it seemed they're not respecting the maxwidth constraints. To be checked thoroughly. Anyway it's a good base to start with.

@jakub-g jakub-g added a commit to jakub-g/ariatemplates that referenced this issue Jan 28, 2013

@jakub-g jakub-g feat #80 bindable width and height for containers
Adds possibility to bind width and height for some of container-based
widgets (Div, Dialog, Fieldset, TabPanel). The bound size is a subject to
min/max size constraints for all of those widgets.

This commit lifts the requirement for widgets to have width/height = -1
for min/max width/height to work. So this is backward-incompatible change
in some way, but the behavior of width & maxwidth etc. when provided
together was undefined earlier, so it should not have relied upon by anyone.

Apart from the bindable width/height tests, this commit brings also
a test case on static height constraints of the Dialog widget and their
behavior when the contents od the Dialog change due to a refresh.

Close #80. Close #347.
0481664

divdavem closed this in d93ea66 Jan 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment