Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Dialog widget should have bindable width & height #80

Closed
jakub-g opened this Issue · 3 comments

3 participants

@jakub-g
Collaborator

Currently Dialog has bindable xpos and ypos, but not width nor height.

The new feature should comply with min/max width/height.

@jakub-g
Collaborator

I've marked as priority:high as in fact, this should have been done with one of the previous CRs concerning dialog, but was overlooked.

@vratojr vratojr was assigned
@vratojr

In progress.

@vratojr vratojr referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@vratojr vratojr referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@vratojr vratojr referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@vratojr vratojr referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@vratojr vratojr referenced this issue from a commit
Simone Vratogna Closes #80 - bindable width and height for Containers
Updated the Beans in order to take in account that "ResizableWidgetCfg" now declares bindings.
Updated dialog in order to react to resize correctly when bound.
Fixed div in order to have a proper call to container resizing method.
3152607
@jakub-g
Collaborator

It will be good to write unit tests and finally finish this some day soon (perhaps I'll take it when I have more time, but other volunteers appreciated :))

BTW I've played with the Simone's code and samples, but it seemed they're not respecting the maxwidth constraints. To be checked thoroughly. Anyway it's a good base to start with.

@jakub-g jakub-g referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@jakub-g jakub-g referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@jakub-g jakub-g referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@jakub-g jakub-g referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@jakub-g jakub-g referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@jakub-g jakub-g referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@jakub-g jakub-g referenced this issue from a commit in jakub-g/ariatemplates
@jakub-g jakub-g feat #80 bindable width and height for containers
Adds possibility to bind width and height for some of container-based
widgets (Div, Dialog, Fieldset, TabPanel). The bound size is a subject to
min/max size constraints for all of those widgets.

This commit lifts the requirement for widgets to have width/height = -1
for min/max width/height to work. So this is backward-incompatible change
in some way, but the behavior of width & maxwidth etc. when provided
together was undefined earlier, so it should not have relied upon by anyone.

Apart from the bindable width/height tests, this commit brings also
a test case on static height constraints of the Dialog widget and their
behavior when the contents od the Dialog change due to a refresh.

Close #80. Close #347.
0481664
@divdavem divdavem referenced this issue from a commit in divdavem/ariatemplates
@jakub-g jakub-g feat #80 bindable width and height for containers
Adds possibility to bind width and height for some of container-based
widgets (Div, Dialog, Fieldset, TabPanel). The bound size is a subject to
min/max size constraints for all of those widgets.

This commit lifts the requirement for widgets to have width/height = -1
for min/max width/height to work. So this is backward-incompatible change
in some way, but the behavior of width & maxwidth etc. when provided
together was undefined earlier, so it should not have relied upon by anyone.

Apart from the bindable width/height tests, this commit brings also
a test case on static height constraints of the Dialog widget and their
behavior when the contents od the Dialog change due to a refresh.

Close #80. Close #347.
d93ea66
@divdavem divdavem closed this issue from a commit
@jakub-g jakub-g feat #80 bindable width and height for containers
Adds possibility to bind width and height for some of container-based
widgets (Div, Dialog, Fieldset, TabPanel). The bound size is a subject to
min/max size constraints for all of those widgets.

This commit lifts the requirement for widgets to have width/height = -1
for min/max width/height to work. So this is backward-incompatible change
in some way, but the behavior of width & maxwidth etc. when provided
together was undefined earlier, so it should not have relied upon by anyone.

Apart from the bindable width/height tests, this commit brings also
a test case on static height constraints of the Dialog widget and their
behavior when the contents od the Dialog change due to a refresh.

Close #80. Close #347.
d93ea66
@divdavem divdavem closed this in d93ea66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.