Lacking good regression test for template API #954

Closed
jakub-g opened this Issue Jan 27, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@jakub-g
Collaborator

jakub-g commented Jan 27, 2014

http://snippets.ariatemplates.com/samples/github.com/ariatemplates/documentation-code/tree/master/samples/templates/domInteractions/focushandling/templateAPI

The commit 8fcb182 (which was later reverted before 1.4.15 was released) made the mentioned sample not work properly in IE8 (the focus was not given back properly to the template after the refresh) but none of our tests failed in the campaign.

There should be a unit test written (or improved if there's one already) that will be red with this commit and green without it.

flongo added a commit to flongo/ariatemplates that referenced this issue Jan 28, 2014

fix #954 Improvement of the focus template API test
An existing test (test.aria.templates.focusAfterRefresh.FocusTemplateTestCase) has been improved in order to actually test that the focus is given back to the widget that had it before a refresh.

flongo added a commit to flongo/ariatemplates that referenced this issue Jan 28, 2014

fix #954 Improvement of the focus template API test
An existing test (test.aria.templates.focusAfterRefresh.FocusTemplateTestCase) has been improved in order to actually test that the focus is given back to the widget that had it before a refresh.

Close #959.

flongo added a commit to flongo/ariatemplates that referenced this issue Jan 29, 2014

fix #954 Improvement of the focus template API test
An existing test (test.aria.templates.focusAfterRefresh.FocusTemplateTestCase) has been improved in order to actually test that the focus is given back to the widget that had it before a refresh.

Close #959.

flongo added a commit to flongo/ariatemplates that referenced this issue Jan 29, 2014

fix #954 Improvement of the focus template API test
An existing test (test.aria.templates.focusAfterRefresh.FocusTemplateTestCase) has been improved in order to actually test that the focus is given back to the widget that had it before a refresh.

Close #959.

@flongo flongo closed this in 19936ea Jan 29, 2014

@flongo flongo added this to the 1.4.16 milestone Feb 14, 2014

carlo-mr added a commit to carlo-mr/ariatemplates that referenced this issue Mar 3, 2014

fix #954 Improvement of the focus template API test
An existing test (test.aria.templates.focusAfterRefresh.FocusTemplateTestCase) has been improved in order to actually test that the focus is given back to the widget that had it before a refresh.

Close #959.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment