Non-delegated events are now correctly raised on html widgets #1094

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@divdavem
Member

divdavem commented Apr 17, 2014

This pull request fixes the following issue: non-delegated events were not raised on html widgets (the event mechanism implemented in aria.html.Element did no check whether events were delegated or not).

With this fix, if an event is not delegated, the fallback markup is added so that the handler is correctly called.

Especially, the onchange event on the html select widget is now correctly raised on IE 7-10, which fixes test.aria.html.select.onchange.DataModelOnChangeTestCase.

fix #1094 non-delegated events are now correctly raised on html widgets
Especially, the onchange event on the html select widget is now correctly
raised on IE 7-10, which fixes test.aria.html.select.onchange.DataModelOnChangeTestCase.
@divdavem

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Apr 17, 2014

Member

This pull request is related to #1087, #1088 and #1078.

Member

divdavem commented Apr 17, 2014

This pull request is related to #1087, #1088 and #1078.

@simonarbuckle

This comment has been minimized.

Show comment Hide comment
@simonarbuckle

simonarbuckle Apr 18, 2014

Collaborator

it is fine for me.

Collaborator

simonarbuckle commented Apr 18, 2014

it is fine for me.

@divdavem divdavem closed this in 367aab2 Apr 18, 2014

@simonarbuckle simonarbuckle added this to the 1.5.2 milestone Apr 18, 2014

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Oct 16, 2014

fix #1094 non-delegated events are now correctly raised on html widgets
Especially, the onchange event on the html select widget is now correctly
raised on IE 7-10, which fixes test.aria.html.select.onchange.DataModelOnChangeTestCase.

(cherry picked from commit 367aab2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment