Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span elements made focusable by Firefox when overflow-y:hidden is used alone #1569

Closed
wants to merge 1 commit into from

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Jan 6, 2016

This PR makes sure we always specify both overflow-x and overflow-y (or none of them) so that Firefox does not make the corresponding <span> element focusable when it is not supposed to be focusable.

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 6, 2016
…hidden is used

This commit adds tabindex="-1" on <span> elements which can contain the
overflow-x:hidden or overflow-y:hidden CSS styles, so that they are no
longer made focusable by Firefox.

IR 10616666
divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 6, 2016
…hidden is used

This commit adds tabindex="-1" on <span> elements which can contain the
overflow-x:hidden or overflow-y:hidden CSS styles, so that they are no
longer made focusable by Firefox.

IR 10616666
…y:hidden is used

This commit makes sure we always specify both overflow-x and overflow-y
(or none of them) so that Firefox does not make the corresponding <span>
element focusable when it is not supposed to be focusable.

IR 10616666
@divdavem divdavem changed the title span elements made focusable by Firefox when overflow:hidden is used span elements made focusable by Firefox when overflow-y:hidden is used alone Jan 6, 2016
@fbasso
Copy link
Member

fbasso commented Jan 6, 2016

22c64bb is fine for me

@divdavem
Copy link
Member Author

divdavem commented Jan 6, 2016

@fbasso Thank you for your review

@divdavem divdavem closed this in dcc3bd8 Jan 6, 2016
divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 6, 2016
…y:hidden is used

This commit makes sure we always specify both overflow-x and overflow-y
(or none of them) so that Firefox does not make the corresponding <span>
element focusable when it is not supposed to be focusable.

IR 10616666

(cherry picked from commit dcc3bd8)
divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 6, 2016
…y:hidden is used

This commit makes sure we always specify both overflow-x and overflow-y
(or none of them) so that Firefox does not make the corresponding <span>
element focusable when it is not supposed to be focusable.

IR 10616666

(cherry picked from commit dcc3bd8)
divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 7, 2016
…y:hidden is used

This commit makes sure we always specify both overflow-x and overflow-y
(or none of them) so that Firefox does not make the corresponding <span>
element focusable when it is not supposed to be focusable.

IR 10616666

(cherry picked from commit dcc3bd8)
@simonarbuckle simonarbuckle added this to the 1.7.16 milestone Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants