Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing specific versions of Chrome and Firefox in testConfigBuilder.js #1732

Merged

Conversation

divdavem
Copy link
Member

This avoids having to update the repository for each new version of those browsers.

@divdavem divdavem force-pushed the removingSpecificBrowserVersions branch from 421b52a to 6f14aa2 Compare November 24, 2016 14:41
divdavem added a commit to divdavem/ariatemplates that referenced this pull request Nov 24, 2016
… Firefox with "latest"

This avoids having to update the repository for each new version of those
browsers.
…Firefox in test config

This avoids having to update the repository for each new version of those
browsers.
@divdavem divdavem force-pushed the removingSpecificBrowserVersions branch from 6f14aa2 to fb84304 Compare November 24, 2016 14:53
@divdavem divdavem changed the title Replacing specific versions of Chrome and Firefox with "latest" in testConfigBuilder.js Removing specific versions of Chrome and Firefox in testConfigBuilder.js Nov 24, 2016
Copy link
Contributor

@ymeine ymeine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for me!

@divdavem
Copy link
Member Author

@ymeine Thank you for your review!

@divdavem divdavem merged commit ff76393 into ariatemplates:master Nov 24, 2016
@divdavem divdavem added this to the 1.8.1 milestone Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants