New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep existing log appenders in aria.jsunit.Assert #1758

Merged
merged 2 commits into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@divdavem
Member

divdavem commented Feb 27, 2017

Before this PR, creating an instance of aria.jsunit.Assert (the base class for most tests) cleared all appenders in aria.core.Log. Now, this class only manages its own appender to collect errors during tests and no longer impacts any other appender.
See also #590.

Also, a second commit in the PR removes the deprecation messages for unloadClass and getFilename as those methods are used in the framework itself (especially in base test classes but also in some other places) and the messages can then be confusing for an application developer which does not call those methods directly, and those messages are more visible in test logs if appenders are not cleared (and they are no longer cleared in the Assert class).

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 27, 2017

feat #1758 Keep existing log appenders in aria.jsunit.Assert
Before this commit, creating an instance of aria.jsunit.Assert (the base
class for most tests) cleared all appenders in aria.core.Log. Now, this
class only manages its own appender to collect errors during tests and
no longer impacts any other appender.
See also #590.

close #1758

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 27, 2017

fix #1758 Removing deprecation of getFilename and unloadClass
This commit removes deprecation messages for getFilename and unloadClass,
as these methods are used inside the framework itself (especially in base
test classes but also in some other places) and the messages can then be
confusing for an application developer who does not call those methods
directly, and those messages are more visible in test logs if appenders
are not cleared (and they are no longer cleared in the Assert class).

close #1758

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 27, 2017

feat #1758 Keep existing log appenders in aria.jsunit.Assert
Before this commit, creating an instance of aria.jsunit.Assert (the base
class for most tests) cleared all appenders in aria.core.Log. Now, this
class only manages its own appender to collect errors during tests and
no longer impacts any other appender.
See also #590.

close #1758

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 27, 2017

fix #1758 Removing deprecation of getFilename and unloadClass
This commit removes deprecation messages for getFilename and unloadClass,
as these methods are used inside the framework itself (especially in base
test classes but also in some other places) and the messages can then be
confusing for an application developer who does not call those methods
directly, and those messages are more visible in test logs if appenders
are not cleared (and they are no longer cleared in the Assert class).

close #1758

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 27, 2017

feat #1758 Keep existing log appenders in aria.jsunit.Assert
Before this commit, creating an instance of aria.jsunit.Assert (the base
class for most tests) cleared all appenders in aria.core.Log. Now, this
class only manages its own appender to collect errors during tests and
no longer impacts any other appender.
See also #590.

close #1758

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 27, 2017

fix #1758 Removing deprecation of getFilename and unloadClass
This commit removes deprecation messages for getFilename and unloadClass,
as these methods are used inside the framework itself (especially in base
test classes but also in some other places) and the messages can then be
confusing for an application developer who does not call those methods
directly, and those messages are more visible in test logs if appenders
are not cleared (and they are no longer cleared in the Assert class).

close #1758

divdavem added some commits Feb 27, 2017

feat #1758 Keep existing log appenders in aria.jsunit.Assert
Before this commit, creating an instance of aria.jsunit.Assert (the base
class for most tests) cleared all appenders in aria.core.Log. Now, this
class only manages its own appender to collect errors during tests and
no longer impacts any other appender.
See also #590.

close #1758
fix #1758 Removing deprecation of getFilename and unloadClass
This commit removes deprecation messages for getFilename and unloadClass,
as these methods are used inside the framework itself (especially in base
test classes but also in some other places) and the messages can then be
confusing for an application developer who does not call those methods
directly, and those messages are more visible in test logs if appenders
are not cleared (and they are no longer cleared in the Assert class).

close #1758
@fbasso

fbasso approved these changes Feb 27, 2017

@divdavem

This comment has been minimized.

Show comment
Hide comment
@divdavem

divdavem Feb 27, 2017

Member

@fbasso Thank you for your review!

Member

divdavem commented Feb 27, 2017

@fbasso Thank you for your review!

@divdavem divdavem merged commit 6c0e3ac into ariatemplates:master Feb 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@divdavem divdavem added this to the 1.8.3 milestone Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment