Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding restoreFocusOnClose parameter in Dialog widget #1790

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@divdavem
Copy link
Member

divdavem commented Feb 16, 2018

This commit adds the "restoreFocusOnClose" parameter on the Dialog widget, which is true by default (to keep the same behavior as before which restores the focus to the element that was focused before the dialog was opened when the dialog is closed) but which can now also be set to false (either directly in the configuration, or through a binding) to disable the automatic restoration of the focus. This is especially useful if the application manages the focus itself when the dialog is closed and does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never restored in that case).

@divdavem divdavem requested a review from ymeine Feb 16, 2018

@divdavem divdavem force-pushed the divdavem:dialogRestoreFocusOnClose branch from 959fb76 to bdcf8f8 Feb 16, 2018

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 16, 2018

feat ariatemplates#1790 Adding restoreFocusOnClose parameter in Dialo…
…g widget

This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close #xxx

@divdavem divdavem force-pushed the divdavem:dialogRestoreFocusOnClose branch from bdcf8f8 to e396377 Feb 16, 2018

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 16, 2018

feat ariatemplates#1790 Adding restoreFocusOnClose parameter in Dialo…
…g widget

This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close ariatemplates#1790

@divdavem divdavem force-pushed the divdavem:dialogRestoreFocusOnClose branch from e396377 to f50285a Feb 16, 2018

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 16, 2018

feat ariatemplates#1790 Adding restoreFocusOnClose parameter in Dialo…
…g widget

This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close ariatemplates#1790

@divdavem divdavem force-pushed the divdavem:dialogRestoreFocusOnClose branch from f50285a to 2fd55bd Feb 16, 2018

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 16, 2018

feat ariatemplates#1790 Adding restoreFocusOnClose parameter in Dialo…
…g widget

This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close ariatemplates#1790
feat #1790 Adding restoreFocusOnClose parameter in Dialog widget
This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close #1790

@divdavem divdavem force-pushed the divdavem:dialogRestoreFocusOnClose branch from 2fd55bd to f05708b Feb 16, 2018

@ymeine

ymeine approved these changes Feb 16, 2018

Copy link
Member

ymeine left a comment

Very good! Thanks for the feature

@divdavem

This comment has been minimized.

Copy link
Member Author

divdavem commented Feb 16, 2018

@ymeine Thank you for your review!

@divdavem divdavem merged commit 8124437 into ariatemplates:master Feb 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ymeine added a commit that referenced this pull request Apr 10, 2018

feat #1790 Adding restoreFocusOnClose parameter in Dialog widget
This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close #1790

(cherry picked from commit 8124437)

ymeine added a commit that referenced this pull request Apr 10, 2018

feat #1790 Adding restoreFocusOnClose parameter in Dialog widget
This commit adds the "restoreFocusOnClose" parameter on the Dialog widget,
which is true by default (to keep the same behavior as before which
restores the focus to the element that was focused before the dialog
was opened when the dialog is closed) but which can now also be set to
false (either directly in the configuration, or through a binding) to
disable the automatic restoration of the focus. This is especially useful
if the application manages the focus itself when the dialog is closed and
does not want the framework to interfere.
This parameter is ignored for non-modal dialogs (the focus is never
restored in that case).

IR 14698018
close #1790

(cherry picked from commit 8124437)

@divdavem divdavem added this to the 2.3.0 milestone Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.