New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blurBeforeAction option in aria:Button configuration #1794

Merged
merged 2 commits into from Apr 27, 2018

Conversation

Projects
None yet
2 participants
@divdavem
Member

divdavem commented Apr 26, 2018

If blurBeforeAction is true, the button blurs any other focused element on the page before calling the onclick handler.

This is especially useful to solve issues with screen readers (such as JAWS) that can click on a button without changing the focus, and if the focus is still in a field, the data model may contain an old value because the value is usually only updated in the data model on blur.

divdavem added some commits Apr 26, 2018

feat #1794 Adding blurBeforeAction option in @aria:Button configuration
If blurBeforeAction is true, the button blurs any other focused element
on the page before calling the onclick handler.

PTR 15067407
close #1794

@divdavem divdavem requested a review from ymeine Apr 27, 2018

@ymeine

ymeine approved these changes Apr 27, 2018

All good for me! :)

@divdavem

This comment has been minimized.

Member

divdavem commented Apr 27, 2018

@ymeine Thank you for your review!

@divdavem divdavem merged commit 069cc93 into ariatemplates:master Apr 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

divdavem added a commit that referenced this pull request Apr 27, 2018

feat #1794 Adding blurBeforeAction option in @aria:Button configuration
If blurBeforeAction is true, the button blurs any other focused element
on the page before calling the onclick handler.

PTR 15067407
close #1794

(cherry picked from commit af8fa9a)

@divdavem divdavem added this to the 2.3.0 milestone Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment