Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autocomplete and name properties to text input widgets #1807

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@divdavem
Copy link
Member

commented Jan 16, 2019

No description provided.

@divdavem divdavem requested a review from benouat Jan 16, 2019

@divdavem divdavem force-pushed the divdavem:autocompleteAttribute branch from 8926929 to 003e58f Jan 16, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 16, 2019

Codecov Report

Merging #1807 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
+ Coverage   81.01%   81.02%   +<.01%     
==========================================
  Files         599      599              
  Lines       33644    33650       +6     
==========================================
+ Hits        27256    27264       +8     
+ Misses       6388     6386       -2
Impacted Files Coverage Δ
src/aria/widgets/CfgBeans.js 100% <ø> (ø) ⬆️
src/aria/widgets/form/TextInput.js 91.8% <100%> (+0.1%) ⬆️
...widgets/controllers/MultiAutoCompleteController.js 95.41% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410d832...003e58f. Read the comment docs.

@divdavem

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

@benouat Thank you for your review!

@divdavem divdavem merged commit 111c3c1 into ariatemplates:master Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 22, 2019

feat ariatemplates#1807 Adding autocomplete and name properties to te…
…xt input widgets

PTR 16220515

(cherry picked from commit 111c3c1)

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 22, 2019

feat ariatemplates#1807 Adding autocomplete and name properties to te…
…xt input widgets

PTR 16220515

(cherry picked from commit 111c3c1)

@divdavem divdavem added this to the 2.4.0 milestone Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.