Autoselect for HTML Text Input #272

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@fab-b
Contributor

fab-b commented Dec 11, 2012

No description provided.

@ghost ghost assigned divdavem Dec 14, 2012

@divdavem

View changes

src/aria/html/TextInput.js
+ /**
+ * Flag set to false after first focus, and set back to true after a blur. Used for the autoselect behaviour.
+ * This value is true when the field receives focus for the first time (user action) and false when the focus is
+ * giveng programmatically by the controller

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Dec 14, 2012

Member

Should be 'given' instead of 'giveng'

@divdavem

divdavem Dec 14, 2012

Member

Should be 'given' instead of 'giveng'

@divdavem

View changes

src/aria/html/TextInput.js
+
+ /**
+ * Add special listeners on top of the ones specified in configuration.
+ * @param {aria.html.beans.TextInputCfg.Properties} listeners On listeners taken from the widget configuration.

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Dec 14, 2012

Member

JSDoc has to be updated: the first parameter is now the whole configuration and not only 'On' listeners.

@divdavem

divdavem Dec 14, 2012

Member

JSDoc has to be updated: the first parameter is now the whole configuration and not only 'On' listeners.

@divdavem

View changes

src/aria/html/beans/TextInputCfg.js
+ },
+ "autoselect" : {
+ $type : "json:Boolean",
+ $description : "Autoselect for the input field.",

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Dec 14, 2012

Member

I think the description should describe the feature more precisely. For example: "If true, the whole field is automatically selected when the user clicks on it."

@divdavem

divdavem Dec 14, 2012

Member

I think the description should describe the feature more precisely. For example: "If true, the whole field is automatically selected when the user clicks on it."

@divdavem

View changes

src/aria/utils/Caret.js
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
+ * either express or implied. See the License for the specific language governing permissions and limitations under the
+ * License.
+ */

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Dec 14, 2012

Member

There seems to be a formatting issue with the license header.

@divdavem

divdavem Dec 14, 2012

Member

There seems to be a formatting issue with the license header.

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Dec 17, 2012

@divdavem

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Dec 17, 2012

Member

👍
Integrated in bbed68b.

Member

divdavem commented Dec 17, 2012

👍
Integrated in bbed68b.

@divdavem divdavem closed this Dec 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment