Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

feat #342 $description no longer mandatory in bean definitions #343

Closed
wants to merge 1 commit into from

2 participants

@flongo
Collaborator

No description provided.

@divdavem divdavem was assigned
@divdavem
Collaborator

Integrated in 39259a2

@divdavem divdavem closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
3  src/aria/core/BaseTypes.js
@@ -35,8 +35,7 @@ Aria.beanDefinitions({
},
'$description' : {
$type : "json:String",
- $description : "A literal description of the package and its purpose.",
- $mandatory : true
+ $description : "A literal description of the package and its purpose."
},
'$dependencies' : {
View
5 src/aria/core/JsonValidator.js
@@ -175,7 +175,6 @@
INVALID_DEFAULTVALUE : "Default value %1 in %2 is invalid: %3",
BEANCHECK_FAILED : "Checking bean definition %1 with beans schema failed: %2",
MISSING_ENUMVALUES : "$enumValues must be defined and non-empty in the Enum definition in %1",
- MISSING_DESCRIPTION : "Missing $description in %1",
INVALID_NAME : "Invalid name for a bean: %1 in %2",
NUMBER_INVALID_INHERITANCE : "Invalid inheritance: %1 in %2 should respect its parent range",
NUMBER_INVALID_RANGE : "Invalid range in %1: %2-%3",
@@ -387,10 +386,6 @@
if (!beanDef.$description && !typeRef[this._MD_BUILTIN]) {
beanDef.$description = typeRef.$description;
}
- if (!beanDef.$description && beanDef.$description !== "") {
- this._logError(this.MISSING_DESCRIPTION, beanDef[this._MD_TYPENAME]);
- return this._typeError;
- }
var hasNoDefault = !("$default" in beanDef), hasNoMandatory = !("$mandatory" in beanDef);
View
7 test/aria/core/JsonValidatorTest.js
@@ -243,13 +243,6 @@ Aria.classDefinition({
}
}
}, {
- errorMsgs : [jv.MISSING_DESCRIPTION],
- beans : {
- TestBean : {
- $type : "json:String"
- }
- }
- }, {
errorMsgs : [jv.MISSING_ENUMVALUES],
beans : {
TestBean : {
Something went wrong with that request. Please try again.