Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

feat #342 $description no longer mandatory in bean definitions #343

Closed
wants to merge 1 commit into
from
Jump to file or symbol
Failed to load files and symbols.
+1 −14
Split
@@ -35,8 +35,7 @@ Aria.beanDefinitions({
},
'$description' : {
$type : "json:String",
- $description : "A literal description of the package and its purpose.",
- $mandatory : true
+ $description : "A literal description of the package and its purpose."
},
'$dependencies' : {
@@ -175,7 +175,6 @@
INVALID_DEFAULTVALUE : "Default value %1 in %2 is invalid: %3",
BEANCHECK_FAILED : "Checking bean definition %1 with beans schema failed: %2",
MISSING_ENUMVALUES : "$enumValues must be defined and non-empty in the Enum definition in %1",
- MISSING_DESCRIPTION : "Missing $description in %1",
INVALID_NAME : "Invalid name for a bean: %1 in %2",
NUMBER_INVALID_INHERITANCE : "Invalid inheritance: %1 in %2 should respect its parent range",
NUMBER_INVALID_RANGE : "Invalid range in %1: %2-%3",
@@ -387,10 +386,6 @@
if (!beanDef.$description && !typeRef[this._MD_BUILTIN]) {
beanDef.$description = typeRef.$description;
}
- if (!beanDef.$description && beanDef.$description !== "") {
- this._logError(this.MISSING_DESCRIPTION, beanDef[this._MD_TYPENAME]);
- return this._typeError;
- }
var hasNoDefault = !("$default" in beanDef), hasNoMandatory = !("$mandatory" in beanDef);
@@ -242,13 +242,6 @@ Aria.classDefinition({
$description : ""
}
}
- }, {
- errorMsgs : [jv.MISSING_DESCRIPTION],
- beans : {
- TestBean : {
- $type : "json:String"
- }
- }
}, {
errorMsgs : [jv.MISSING_ENUMVALUES],
beans : {