fix #349 maxwidth/maxheight issue in Dialog #359

Closed
wants to merge 1 commit into
from

2 participants

@jakub-g

After delivering #349 via commit 29331b1
a regresion was found during release testing: maxwidth/maxheight
constraints of the Dialog were calculated too big due to addition of the
shadow. That addition should be done only in maximized mode.

@jakub-g jakub-g fix #349 maxwidth/maxheight issues in Dialog
After delivering #349 via commit 29331b1
a regresion was found during release testing: maxwidth/maxheight
constraints of the Dialog were calculated too big due to addition of the
shadow. That addition should be done only in maximized mode.

Moreover, the Dialog was not correctly resized in maximized mode when
it had maxWidth/maxHeight set. Now that properties are ignored in
maximized mode.

Close #359.
e1a1d55
@piuccio piuccio added a commit that closed this pull request Feb 4, 2013
@jakub-g jakub-g fix #349 maxwidth/maxheight issues in Dialog
After delivering #349 via commit 29331b1
a regresion was found during release testing: maxwidth/maxheight
constraints of the Dialog were calculated too big due to addition of the
shadow. That addition should be done only in maximized mode.

Moreover, the Dialog was not correctly resized in maximized mode when
it had maxWidth/maxHeight set. Now that properties are ignored in
maximized mode.

Close #359.
3e7dfe4
@piuccio piuccio closed this in 3e7dfe4 Feb 4, 2013
@piuccio

Integrated in 3e7dfe4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment