Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

AT 1.4.1 backward incompatible features removal #427

Closed
wants to merge 17 commits into from

2 participants

@jakub-g
Collaborator

This is a pack of commits that have been tested and are not causing any problems anymore (hopefully). Including global CSS splitting & removal of some page-global CSS.

The order of removal commits resembles the deprecation time of the features (older commits are for things deprecated in 1.0.x, then 1.1.x, then 1.2.x). I think we should keep all the commits instead of squashing everything.

Things not included in this pull request (some things still to resolve / decide):

  • Deprecation/removal of cssClass - see #398
  • changing aria.templates.ModuleCtrl._enableMethodEvents to false and all the things that follow from it
  • turning on the escape of HTML in the templates
@jakub-g
Collaborator

Ready for review & integration.

jakub-g added some commits
@jakub-g jakub-g deprecate IconLib e448869
@jakub-g jakub-g refactor remove obsolete JSDoc in SimpleSessionQueuing c4d9fc9
@jakub-g jakub-g deprecate bindRefreshTo statement 7a46187
@jakub-g jakub-g refactor remove EnvironmentBase.setEnvironment 48a5586
@jakub-g jakub-g refactor remove SubModuleDefinition.display from CfgBeans
It was not used anywhere in the code.
756b732
@jakub-g jakub-g refactor remove deprecated methods from AriaLib e46c8f5
@jakub-g jakub-g refactor remove deprecated members of environment.WidgetSettings
Removed the following methods and cfgBeans members:
getWidgetLib()
getWidgetLibClassName()
defaultWidgetLib

The supported equivalents are:
aria.widgetLibs.environment.WidgetLibsSettings.getWidgetLibs,
aria.widgetLibs.environment.WidgetLibsSettingsCfgBeans.AppCfg.defaultWidgetLibs
and Aria.getClassRef.
b2e09a3
@jakub-g jakub-g refactor remove deprecated _formatCache in utils.Number 9e76e14
@jakub-g jakub-g refactor remove utils.Event.getElement 3041736
@jakub-g jakub-g refactor remove onvalidate from TextInput and Select 49a4f99
@jakub-g jakub-g refactor remove legacy way of declaring objects in an interface
objects in interface definition are no longer represented as {},
but either as {$type: "Object"} or a shortcut notation "Object"
19c7f09
@jakub-g jakub-g refactor remove color from Link 083d87e
@jakub-g jakub-g refactor remove Date.firstDayOfWeek
Supported equivalent is now aria.core.AppEnvironment.firstDayOfWeek
39ec3fe
@jakub-g jakub-g refactor remove deprecated usage of expandos in DomElementWrapper
DomElementWrapper.getData() no longer internally checks for expandos
prefixed with '_'. Please use 'data-' prefix for expandos.

Most of the related code was removed in AT 1.3.1, this is just leftovers
that were omitted that time.
9259ebc
@jakub-g jakub-g refactor remove OldFrame b224cb8
@jakub-g jakub-g refactor remove deprecated utils.FormatFactory c9931d1
@jakub-g jakub-g refactor global style split & removal
1) Removed page-global CSS from 'widgets.GlobalStyle' and extracted
some of it into 'templates.LegacyGeneralStyle', which is automatically
loaded for backward compatibility in templates when AriaSkin is available.

2) "aria.widgets.GlobalStyle" is loaded only when widgets are present.

3) Removed skin from bootstrap.js. Added skin in attester config instead.

4) In AriaSkinBeans: renamed "GeneralCfg" to "PageGeneralCfg"; removed some
deprecated items from it; created "WidgetGeneralCfg" being subset of
"PageGeneralCfg" to be able to separate font settings for widgets from
font settings for the page in general. This followed some changes in
skin normalization.
f67213f
@divdavem
Collaborator

Integrated in:

  • 9b4d380 (deprecate IconLib)
  • 9596760 (deprecate bindRefreshTo statement)
  • 6e969ef (refactor remove obsolete JSDoc in SimpleSessionQueuing)
  • dca6478 (refactor remove SubModuleDefinition.display from CfgBeans)
  • 12a4429 (refactor remove EnvironmentBase.setEnvironment)
  • 8a458a8 (refactor remove deprecated members of environment.WidgetSettings)
  • 716bf6f (refactor remove deprecated methods from AriaLib)
  • fe0937a (refactor remove utils.Event.getElement)
  • 120981a (refactor remove deprecated _formatCache in utils.Number)
  • b8abd21 (refactor remove onvalidate from TextInput and Select)
@divdavem
Collaborator
  • b4ede3d (refactor remove legacy way of declaring objects in an interface)
  • 4ec904a (refactor remove color from Link)
  • b88bc51 (refactor remove deprecated usage of expandos in DomElementWrapper)
  • d9f1e67 (refactor remove Date.firstDayOfWeek)
  • 9811bfc (refactor remove OldFrame)
  • f44de2f (refactor remove deprecated utils.FormatFactory)
  • 59e9ba7 (refactor global style split & removal)
@divdavem divdavem closed this
@jakub-g jakub-g referenced this pull request from a commit in jakub-g/ariatemplates
@jakub-g jakub-g fix #458 error when no skin and no widgets loaded
Due to a bug in the code delivered in 59e9ba7
(pull request #427), when no skin and no widgets were loaded, JavaScript
errors were thrown due to nullpointer exception.
be6ac19
@piuccio piuccio referenced this pull request from a commit
@jakub-g jakub-g fix #458 error when no skin and no widgets loaded
Due to a bug in the code delivered in 59e9ba7
(pull request #427), when no skin and no widgets were loaded, JavaScript
errors were thrown due to nullpointer exception.
de7e2ce
@jakub-g jakub-g deleted the jakub-g:at14 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 21, 2013
  1. @jakub-g

    deprecate IconLib

    jakub-g authored
  2. @jakub-g
  3. @jakub-g
  4. @jakub-g
  5. @jakub-g

    refactor remove SubModuleDefinition.display from CfgBeans

    jakub-g authored
    It was not used anywhere in the code.
  6. @jakub-g
  7. @jakub-g

    refactor remove deprecated members of environment.WidgetSettings

    jakub-g authored
    Removed the following methods and cfgBeans members:
    getWidgetLib()
    getWidgetLibClassName()
    defaultWidgetLib
    
    The supported equivalents are:
    aria.widgetLibs.environment.WidgetLibsSettings.getWidgetLibs,
    aria.widgetLibs.environment.WidgetLibsSettingsCfgBeans.AppCfg.defaultWidgetLibs
    and Aria.getClassRef.
  8. @jakub-g
  9. @jakub-g
  10. @jakub-g
  11. @jakub-g

    refactor remove legacy way of declaring objects in an interface

    jakub-g authored
    objects in interface definition are no longer represented as {},
    but either as {$type: "Object"} or a shortcut notation "Object"
  12. @jakub-g
  13. @jakub-g

    refactor remove Date.firstDayOfWeek

    jakub-g authored
    Supported equivalent is now aria.core.AppEnvironment.firstDayOfWeek
  14. @jakub-g

    refactor remove deprecated usage of expandos in DomElementWrapper

    jakub-g authored
    DomElementWrapper.getData() no longer internally checks for expandos
    prefixed with '_'. Please use 'data-' prefix for expandos.
    
    Most of the related code was removed in AT 1.3.1, this is just leftovers
    that were omitted that time.
  15. @jakub-g

    refactor remove OldFrame

    jakub-g authored
  16. @jakub-g
  17. @jakub-g

    refactor global style split & removal

    jakub-g authored
    1) Removed page-global CSS from 'widgets.GlobalStyle' and extracted
    some of it into 'templates.LegacyGeneralStyle', which is automatically
    loaded for backward compatibility in templates when AriaSkin is available.
    
    2) "aria.widgets.GlobalStyle" is loaded only when widgets are present.
    
    3) Removed skin from bootstrap.js. Added skin in attester config instead.
    
    4) In AriaSkinBeans: renamed "GeneralCfg" to "PageGeneralCfg"; removed some
    deprecated items from it; created "WidgetGeneralCfg" being subset of
    "PageGeneralCfg" to be able to separate font settings for widgets from
    font settings for the page in general. This followed some changes in
    skin normalization.
Something went wrong with that request. Please try again.