Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix #458 error when no skin and no widgets loaded #458

Closed
wants to merge 1 commit into from

1 participant

@jakub-g
Collaborator

Due to a bug in the code delivered in 59e9ba7 (pull request #427), when no skin and no widgets were loaded, JavaScript errors were thrown due to nullpointer exception.

@jakub-g jakub-g fix #458 error when no skin and no widgets loaded
Due to a bug in the code delivered in 59e9ba7
(pull request #427), when no skin and no widgets were loaded, JavaScript
errors were thrown due to nullpointer exception.
be6ac19
@piuccio piuccio closed this pull request from a commit
@jakub-g jakub-g fix #458 error when no skin and no widgets loaded
Due to a bug in the code delivered in 59e9ba7
(pull request #427), when no skin and no widgets were loaded, JavaScript
errors were thrown due to nullpointer exception.
de7e2ce
@piuccio piuccio closed this in de7e2ce
@jakub-g jakub-g deleted the jakub-g:noskin-hotfix branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 11, 2013
  1. @jakub-g

    fix #458 error when no skin and no widgets loaded

    jakub-g authored
    Due to a bug in the code delivered in 59e9ba7
    (pull request #427), when no skin and no widgets were loaded, JavaScript
    errors were thrown due to nullpointer exception.
This page is out of date. Refresh to see the latest.
View
2  src/aria/core/TplClassLoader.js
@@ -150,7 +150,7 @@
}
var cssToReload = ['aria.templates.GlobalStyle'];
- if (aria.widgets.AriaSkin) {
+ if (aria.widgets && aria.widgets.AriaSkin) {
cssToReload.push('aria.templates.LegacyGeneralStyle');
}
if (cfg.reload) {
View
2  src/aria/templates/TemplateCtxt.js
@@ -170,7 +170,7 @@
if (this._globalCssDepsLoaded) {
// PTR 05086835: only unload the global CSS if it was loaded by this instance
var deps = ['aria.templates.GlobalStyle'];
- if (aria.widgets.AriaSkin) {
+ if (aria.widgets && aria.widgets.AriaSkin) {
deps.push('aria.templates.LegacyGeneralStyle');
}
aria.templates.CSSMgr.unloadWidgetDependencies('aria.templates.Template', deps);
Something went wrong with that request. Please try again.