Adding a label.color state property. #599

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

divdavem commented Jul 3, 2013

With this pull request, the color of the label of most input widgets can now be defined as a skin property, depending on the state of the widget.

In the atskin skin, the label of text input widgets and of the select widget now show the disabled state with a different color than the normal state.

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jul 3, 2013

feat #599 Adding a label.color state property.
The color of the label of most input widgets can now be defined
as a skin property, depending on the state of the widget.

In the atskin skin, the label of text input widgets and of the
select widget now show the disabled state with a different
color than the normal state.

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jul 3, 2013

feat #599 Adding a label.color state property.
The color of the label of most input widgets can now be defined
as a skin property, depending on the state of the widget.

In the atskin skin, the label of text input widgets and of the
select widget now show the disabled state with a different
color than the normal state.

Close #599
Contributor

piuccio commented Jul 3, 2013

Would it be possible to create a test case?

I think the same changes should be applied also on CheckBoxStyle.

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jul 4, 2013

feat #599 Adding a label.color state property.
The color of the label of most input widgets can now be defined
as a skin property, depending on the state of the widget.

In the atskin skin, the label of text input widgets and of the
select widget now show the disabled state with a different
color than the normal state. Moreover, the appearance of the
MultiSelect (especially for the focused state) is now more
consistent with other text input widgets.

Close #599
Member

divdavem commented Jul 4, 2013

I have added a test case and changed a few things in commit 4b6c7b8.

Regarding the @aria:CheckBox widget, I did not apply the same changes because this widget is currently managing its own label (replacing the one inherited from aria.widgets.form.Input), and it already updates the color of the label when disabled.

feat #599 Adding a label.color state property.
The color of the label of most input widgets can now be defined
as a skin property, depending on the state of the widget.

In the atskin skin, the label of text input widgets and of the
select widget now show the disabled state with a different
color than the normal state. Moreover, the appearance of the
MultiSelect (especially for the focused state) is now more
consistent with other text input widgets.

Close #599

@divdavem divdavem closed this in 9ca6d16 Jul 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment