aria:List widget refresh on datamodel change #921

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@fab-b
Contributor
fab-b commented Jan 10, 2014

Now when you use aria.utils.Json.add and aria.utils.Json.removeAt functions to add items to an aria:List widget (or to remove one), the list template is refreshed and it displays the new item.

@fab-b fab-b added a commit to fab-b/ariatemplates that referenced this pull request Jan 10, 2014
@fab-b fab-b feat #921 aria:List widget refresh on datamodel change
Now when you use aria.utils.Json.add and aria.utils.Json.removeAt functions to add items to an aria:List widget (or to remove one), the list template is refreshed and it displays the new item.
fdaf418
@fab-b fab-b added a commit to fab-b/ariatemplates that referenced this pull request Jan 17, 2014
@fab-b fab-b feat #921 aria:List widget refresh on datamodel change
Now when you use aria.utils.Json.add and aria.utils.Json.removeAt functions to add items to an aria:List widget (or to remove one), the list template is refreshed and it displays the new item.
5674596
@benouat benouat was assigned Jan 20, 2014
@fab-b fab-b added a commit to fab-b/ariatemplates that referenced this pull request Jan 21, 2014
@fab-b fab-b feat #921 aria:List widget refresh on datamodel change
Now when you use aria.utils.Json.add and aria.utils.Json.removeAt functions to add items to an aria:List widget (or to remove one), the list template is refreshed and it displays the new item.
e60f852
@benouat benouat commented on an outdated diff Jan 22, 2014
src/aria/widgetLibs/BindableWidget.js
@@ -73,37 +73,40 @@ Aria.classDefinition({
* @protected
*/
_registerBindings : function () {
- var bindings = this._cfg.bind, jsonUtils = aria.utils.Json;
+ var bindings = this._cfg.bind;
if (bindings) {
for (var property in bindings) {
if (!bindings.hasOwnProperty(property)) {
continue;
@benouat
benouat Jan 22, 2014 Member

What about doing that instead ?

for (var property in bindings) {
  if (bindings.hasOwnProperty(property)) {
    this._registerSingleProperty(property);
  }
}
@fab-b fab-b feat #921 aria:List widget refresh on datamodel change
Now when you use aria.utils.Json.add and aria.utils.Json.removeAt functions to add items to an aria:List widget (or to remove one), the list template is refreshed and it displays the new item.
be5d243
@fab-b fab-b added a commit that referenced this pull request Jan 22, 2014
@fab-b @benouat fab-b + benouat feat #921 aria:List widget refresh on datamodel change
Now when you use aria.utils.Json.add and aria.utils.Json.removeAt functions to add items to an aria:List widget (or to remove one), the list template is refreshed and it displays the new item.
1bc334f
@benouat
Member
benouat commented Jan 22, 2014

Landed in master as 1bc334f

@benouat benouat closed this Jan 22, 2014
@fab-b fab-b deleted the fab-b:list_widget branch Jan 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment