Enable back test.aria.templates.keyboardNavigation.TableNavTestCase on IE <= 8 #951

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@divdavem
Member

divdavem commented Jan 24, 2014

This pull request contains a new fix for the issue that commit 8fcb182
tried to solve, and which was reverted in commit 82b8cbf.

See also #917

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 24, 2014

fix #951 Enable back test.aria.templates.keyboardNavigation.TableNav…
…TestCase on IE <= 8

This commit is a new fix for the issue that commit 8fcb182
tried to solve, and which was reverted in commit 82b8cbf.

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Jan 24, 2014

fix #951 Enable back test.aria.templates.keyboardNavigation.TableNav…
…TestCase on IE <= 8

This commit is a new fix for the issue that commit 8fcb182
tried to solve, and which was reverted in commit 82b8cbf.

@ghost ghost assigned flongo Jan 28, 2014

src/aria/utils/Delegate.js
@@ -38,6 +38,11 @@ Aria.classDefinition({
$constructor : function () {
+ /**
+ * This variable is set to true on IE 7 and 8 when the focused element was just removed from the DOM.
+ */

This comment has been minimized.

Show comment Hide comment
@flongo

flongo Jan 28, 2014

Collaborator

Missing documentation on the type of the property

@flongo

flongo Jan 28, 2014

Collaborator

Missing documentation on the type of the property

divdavem added a commit to divdavem/ariatemplates that referenced this pull request Feb 7, 2014

fix #951 Enable back test.aria.templates.keyboardNavigation.TableNav…
…TestCase on IE <= 8

This commit is a new fix for the issue that commit 8fcb182
tried to solve, and which was reverted in commit 82b8cbf.
@flongo

This comment has been minimized.

Show comment Hide comment
@flongo

flongo Feb 7, 2014

Collaborator

It looks fine to me. The commits underlying this pull request can be integrated.

Collaborator

flongo commented Feb 7, 2014

It looks fine to me. The commits underlying this pull request can be integrated.

fix #951 Enable back test.aria.templates.keyboardNavigation.TableNav…
…TestCase on IE <= 8

This commit is a new fix for the issue that commit 8fcb182
tried to solve, and which was reverted in commit 82b8cbf.

@divdavem divdavem closed this in 2c1141e Feb 7, 2014

carlo-mr added a commit to carlo-mr/ariatemplates that referenced this pull request Mar 3, 2014

fix #951 Enable back test.aria.templates.keyboardNavigation.TableNav…
…TestCase on IE <= 8

This commit is a new fix for the issue that commit 8fcb182
tried to solve, and which was reverted in commit 82b8cbf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment